From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E52EE7D0AE for ; Thu, 21 Sep 2023 21:43:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231130AbjIUVnm (ORCPT ); Thu, 21 Sep 2023 17:43:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230389AbjIUVnO (ORCPT ); Thu, 21 Sep 2023 17:43:14 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A345244B6 for ; Thu, 21 Sep 2023 13:30:03 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-58cb845f2f2so19387627b3.1 for ; Thu, 21 Sep 2023 13:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695328201; x=1695933001; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=0e0ZFX778bRtqensng9uc874c9hN9XH6Wv7cNf/87eM=; b=Lmcr48QZU9B3SGXe0N7Q03b4eFlKEEdSOEPlzaCPNlMBGZRRSf6v2uEJs4IXu2WFZq +Zmore4QALQOyT074OJx4jdA1Cqy+m7DaTDzIqqn9+7TlKVaetoR9hx0PwK6LIPCnXcR eQSQMbsUJBp8kNhdC9tJ/2o0ea5nhg4Kd/yaqMAJWjAuOEE+vOn/kaq9Tg5mouyz/gYd Nq5CgUUNK57s3Bp8jpkHNq42gy8Fy4e7rY6EpnFUa7gXwkLNhmpFyaw5DeS+IR4ovdDz PQ0d+ejU+OzLAM9QQVkoepNq2pD90SOZifiFaLg0yz9GnRefV9TvcTHGZuL9o5WQKo33 RAaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695328201; x=1695933001; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0e0ZFX778bRtqensng9uc874c9hN9XH6Wv7cNf/87eM=; b=sJsQOcJ7/Vu3gFvcY+ZebPmXTdp6ZbRIwaG8G+etxCRb58gylfDWqJuSjn2J92rCQL tZlhHDTnmOzf8CKpWSquKBuEmI9nA0caf/+XSNpTxaVvRH4mrvow4W2LxE9zXy9aW3GJ fVRVaUn5JwmmzuUBqelGspW0dxfxd1jWcbF4oSz8NXyEef8riVZF7yTcAd/4V6Gi1cRD JzfRe8LJCaxQ6QJVdJH61gJ6f0xeuVQlR9h4UEc3zIDJ+XkvPH3xLHANZmcLpGPGX/ch z3WkoclDBLUh9+CHpR5J8pwu5FlM9aRa+MRiOE/aKacRd+KcSw46A5LUj2lGEM9twyPV OrLQ== X-Gm-Message-State: AOJu0YwwfV5kasaLNAyFflpbVjoiBBis9Aze8ZMRwO+0IUH6SGrHPedk pLIPl9R15nBVnYXT2QwmETAyDHhpgo4= X-Google-Smtp-Source: AGHT+IEUzNA8IyQIMX03s7MMZaciANap7xKc1c5smy0hyixgyh595oKa8SQXXUtwQ8+rycDYPZuRHMWlcrs= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:ad1f:0:b0:59b:db15:a088 with SMTP id l31-20020a81ad1f000000b0059bdb15a088mr93304ywh.3.1695328201599; Thu, 21 Sep 2023 13:30:01 -0700 (PDT) Date: Thu, 21 Sep 2023 13:29:59 -0700 In-Reply-To: Mime-Version: 1.0 References: Message-ID: Subject: Re: [RFC PATCH v2 0/6] KVM: gmem: Implement test cases for error_remove_page From: Sean Christopherson To: isaku.yamahata@intel.com Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com, Michael Roth , Paolo Bonzini , erdemaktas@google.com, Sagi Shahar , David Matlack , Kai Huang , Zhi Wang , chen.bo@intel.com, linux-coco@lists.linux.dev, Chao Peng , Ackerley Tng , Vishal Annapurve , Yuan Yao , Jarkko Sakkinen , Xu Yilun , Quentin Perret , wei.w.wang@intel.com, Fuad Tabba Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 21, 2023, isaku.yamahata@intel.com wrote: > From: Isaku Yamahata > > This patch series is to implement test cases for the KVM gmem error_remove_page > method. > - Update punch hole method to truncate pages > - Add a new ioctl KVM_GUEST_MEMORY_FAILURE to inject memory failure on > offset of gmem Doh. Please try to communicate what you're working on. I was just about to hit SEND on a series to fix the truncation bug, and to add a similar test. I would have happily punted that in your direction, but I had no idea that you were aware of the bug[*], let alone working on a fix. I could have explicitly stated that I was going to fix the bug, but I thought that it was implied that I needed to clean up my own mess. Anyways, I'm going to hit SEND anyways, my changes are slightly different to your patch 1 (truncate needs to happen between begin() and end()) and patch 3 (I added a slightly more comprehensive test). [*] https://lore.kernel.org/all/20230918163647.m6bjgwusc7ww5tyu@amd.com