public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
	leit@meta.com,
	"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" 
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] x86/bugs: Add a separate config for each mitigation
Date: Fri, 6 Oct 2023 03:59:39 -0700	[thread overview]
Message-ID: <ZR/om/SzaPCwzYv7@gmail.com> (raw)
In-Reply-To: <20231006095410.GBZR/ZQmaako5yMhVs@fat_crate.local>

On Fri, Oct 06, 2023 at 11:54:10AM +0200, Borislav Petkov wrote:
> On Thu, Oct 05, 2023 at 11:29:02AM -0700, Linus Torvalds wrote:
> > ...
> > "complex" conditionals may also be annoying, but dammit, they are
> > important documentation about why we do those things, and unlike just
> > comments that will inevitably bit-rot, they have semantics and get
> > tested.
> 
> Thanks for explaining - it does make sense to me.
Thanks for clarifying it.

> So, from the looks of it, we're halfway there:
> 
>  - SPECULATION_MITIGATIONS is there for people who want to whack off the
>    whole crap
> 
>  - the separate Kconfig switches are for people who want to do
>    a finer-grained control. And yeah, they might be annoying the first
>    time but you do them once and then you use the .config forever, like
>    with anything else.
> 
> So yeah, sounds like a plan. Breno, please add Linus' explanation to the
> commit message why we're doing it this way, when sending your new
> version.

Sure, I will update the version 3 of the patchset[1] and add Linus'
explanation plus some new mitigation that showed up in the meantime.

[1] https://lore.kernel.org/all/20230628142129.2468174-1-leitao@debian.org/


      reply	other threads:[~2023-10-06 10:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-28 14:21 [PATCH v3] x86/bugs: Add a separate config for each mitigation leitao
2023-09-28 12:45 ` Breno Leitao
2023-09-28 13:40   ` Dave Hansen
2023-09-28 13:57     ` Breno Leitao
2023-09-28 16:33     ` Pawan Gupta
2023-10-05 16:25   ` Borislav Petkov
2023-10-05 18:29     ` Linus Torvalds
2023-10-06  9:54       ` Borislav Petkov
2023-10-06 10:59         ` Breno Leitao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZR/om/SzaPCwzYv7@gmail.com \
    --to=leitao@debian.org \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jpoimboe@kernel.org \
    --cc=leit@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox