From: Andy Shevchenko <andy@kernel.org>
To: "Duje Mihanović" <duje.mihanovic@skole.hr>
Cc: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Russell King <linux@armlinux.org.uk>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH RFC 1/6] ARM: pxa: Convert Spitz OHCI to GPIO descriptors
Date: Mon, 25 Sep 2023 10:30:44 +0300 [thread overview]
Message-ID: <ZRE3JNVNqFN0knHl@smile.fi.intel.com> (raw)
In-Reply-To: <20230924-pxa-gpio-v1-1-2805b87d8894@skole.hr>
On Sun, Sep 24, 2023 at 06:42:54PM +0200, Duje Mihanović wrote:
> Sharp's Spitz board still uses the legacy GPIO interface for controlling
> a GPIO pin related to the USB host controller.
>
> Convert this function to use the new GPIO descriptor interface.
...
> + pxa_ohci->usb_host = gpiod_get(&pdev->dev, "usb-host", GPIOD_OUT_LOW);
> + if (IS_ERR(pxa_ohci->usb_host)) {
> + dev_warn(&pdev->dev, "failed to get USB host GPIO with %d\n",
> + (int) pxa_ohci->usb_host);
Casting is no go in 99.9% cases in printf(), so use proper specifier.
Hint: Nice looking message can be obtained by using %pe.
> + pxa_ohci->usb_host = NULL;
Instead, call for _optional() API.
> + }
...
> + if (pxa_ohci->usb_host)
> + gpiod_put(pxa_ohci->usb_host);
Linus, Bart, do we have misdesigned _optinal() GPIO APIs?
In GPIOLIB=n, the above requires that redundant check. Shouldn't we replace
gpiod_put() stub to be simply no-op?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-25 7:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 16:42 [PATCH RFC 0/6] ARM: pxa: GPIO descriptor conversions Duje Mihanović
2023-09-24 16:42 ` [PATCH RFC 1/6] ARM: pxa: Convert Spitz OHCI to GPIO descriptors Duje Mihanović
2023-09-25 7:30 ` Andy Shevchenko [this message]
2023-09-27 14:01 ` Linus Walleij
2023-10-01 8:18 ` Andy Shevchenko
2023-10-01 9:21 ` Andy Shevchenko
2023-10-02 8:00 ` Linus Walleij
2023-09-24 16:42 ` [PATCH RFC 2/6] ARM: pxa: Convert Spitz LEDs " Duje Mihanović
2023-09-24 16:42 ` [PATCH RFC 3/6] ARM: pxa: Convert Spitz CF power control " Duje Mihanović
2023-09-24 16:42 ` [PATCH RFC 4/6] ARM: pxa: Convert reset driver " Duje Mihanović
2023-09-25 7:34 ` Andy Shevchenko
2023-09-24 16:42 ` [PATCH RFC 5/6] ARM: pxa: Convert Spitz hsync " Duje Mihanović
2023-09-25 7:36 ` Andy Shevchenko
2023-09-25 15:07 ` Duje Mihanović
2023-09-24 16:42 ` [PATCH RFC 6/6] ARM: pxa: Convert gumstix Bluetooth " Duje Mihanović
2023-09-25 7:37 ` [PATCH RFC 0/6] ARM: pxa: GPIO descriptor conversions Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRE3JNVNqFN0knHl@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=daniel@zonque.org \
--cc=duje.mihanovic@skole.hr \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robert.jarzmik@free.fr \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox