From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4401CE7A96 for ; Mon, 25 Sep 2023 10:34:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231778AbjIYKeF (ORCPT ); Mon, 25 Sep 2023 06:34:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231276AbjIYKeD (ORCPT ); Mon, 25 Sep 2023 06:34:03 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEF6DB3 for ; Mon, 25 Sep 2023 03:33:55 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-99bdeae1d0aso743241766b.1 for ; Mon, 25 Sep 2023 03:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695638034; x=1696242834; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ekCv4qzE66DA9iSUYqv5BiKSB2t3mh63TAlLnqGfHvY=; b=Jtz28gQNbDQCex1zu5TcxEHE3N8LNUjVrSLD+VM8q+/OruhKMtcKpeVoIa2y1FYfkl pNRxkDSWdP78zovMznhZPZJUv7HhwI0FCB1fM/34UOnau1l8LdIcAx6BT4KrrTDOleIh VzDHMX7oFRgrvq1nuK55fXRLEubOpWtg7pd82BJynGArSv6Ln7jpY/lYiSblK7CNT1ZE 7Ayux8l/FCURDfUajgAVJIVGrN10lF9qJHC6D/GAJsNB1ZAGkyu0K3LEf7pG1qHHE662 9OHWCCUZiLLwGSj8WvWrDqR2zAWca1Zk9ag+z7UcIbv7/4vztz2Wtrlg+BVUarG9QwjI kXaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695638034; x=1696242834; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ekCv4qzE66DA9iSUYqv5BiKSB2t3mh63TAlLnqGfHvY=; b=WSwdLwnmlDroGzcqkduJM9FybOfpipJHtDtzX3kHa1Au3+FtFF/x2VTwUHJeVd6b7E YafAjW652GdBzQ73BjhOtCmACtkZd/h5PGs3gWB6+CA4DAW+KNQs6OPpcyytFLk7jHMb WSZusZqKNJHNbQmscCxdU6GK+4z6ooPIjgTvHhNZpQdJ5A7pzfD65z5v9lQuzDAuXt+m KiMHYGheWXyYA8APjYfs3FHylSaMvqv4JH3FYDCmKqh9/NfZQswRFom63aFOMhsvjhIz xXypZXref7bXpLlt0sQU7l6BmbK7mWmdf/26YNFtMmWNSsIen5dLrlR+ok7p1M8TWMFl ZLeQ== X-Gm-Message-State: AOJu0YxlbHYC9ZNN/wapV5bMK+/hJ4uyAuQ97dSqN1MI/MHUuHxeBKnX hcPMYwHF36H1/3VUzHj7/mwTUA== X-Google-Smtp-Source: AGHT+IGDOBf7GsrQglZf0+8h8vnRYXgH/eCzX9qj4ZhPwRp3Mst8jCCWek8RtGVV9RKUTj83nCJXEg== X-Received: by 2002:a17:906:3153:b0:9ae:552a:3d3f with SMTP id e19-20020a170906315300b009ae552a3d3fmr5619986eje.28.1695638034032; Mon, 25 Sep 2023 03:33:54 -0700 (PDT) Received: from linaro.org ([86.120.16.169]) by smtp.gmail.com with ESMTPSA id i18-20020a17090639d200b00982a352f078sm6046747eje.124.2023.09.25.03.33.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 03:33:53 -0700 (PDT) Date: Mon, 25 Sep 2023 13:33:51 +0300 From: Abel Vesa To: Konrad Dybcio Cc: Manivannan Sadhasivam , lpieralisi@kernel.org, kw@linux.com, andersson@kernel.org, bhelgaas@google.com, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: qcom: Add interconnect bandwidth for PCIe Gen4 Message-ID: References: <20230924160713.217086-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23-09-25 10:57:47, Konrad Dybcio wrote: > On 24.09.2023 18:07, Manivannan Sadhasivam wrote: > > PCIe Gen4 supports the interconnect bandwidth of 1969 MBps. So let's add > > the bandwidth support in the driver. Otherwise, the default bandwidth of > > 985 MBps will be used. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > drivers/pci/controller/dwc/pcie-qcom.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > > index 297442c969b6..6853123f92c1 100644 > > --- a/drivers/pci/controller/dwc/pcie-qcom.c > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > > @@ -1384,11 +1384,14 @@ static void qcom_pcie_icc_update(struct qcom_pcie *pcie) > > case 2: > > bw = MBps_to_icc(500); > > break; > > + case 3: > > + bw = MBps_to_icc(985); > > + break; > > default: > > WARN_ON_ONCE(1); > > fallthrough; > > - case 3: > > - bw = MBps_to_icc(985); > > + case 4: > > + bw = MBps_to_icc(1969); > > break; > Are you adding case 4 under `default`? That looks.. bizzare.. That's intentional. You want it to use 1969MBps if there is a different gen value. AFAIU. > > Konrad