From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Christoph Hellwig <hch@lst.de>
Cc: manuel.lauss@gmail.com, arnd@arndb.de,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] MIPS: Alchemy: only build mmc support helpers if au1xmmc is enabled
Date: Mon, 25 Sep 2023 12:43:35 +0200 [thread overview]
Message-ID: <ZRFkVy3kBytSC5y8@alpha.franken.de> (raw)
In-Reply-To: <20230905070656.196274-1-hch@lst.de>
On Tue, Sep 05, 2023 at 09:06:56AM +0200, Christoph Hellwig wrote:
> While commit d4a5c59a955b ("mmc: au1xmmc: force non-modular build and
> remove symbol_get usage") to be built in, it can still build a kernel
> without MMC support and thuse no mmc_detect_change symbol at all.
>
> Add ifdefs to build the mmc support code in the alchemy arch code
> conditional on mmc support.
>
> Fixes: d4a5c59a955b ("mmc: au1xmmc: force non-modular build and remove symbol_get usage")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/mips/alchemy/devboards/db1000.c | 4 ++++
> arch/mips/alchemy/devboards/db1200.c | 6 ++++++
> arch/mips/alchemy/devboards/db1300.c | 4 ++++
> 3 files changed, 14 insertions(+)
applied to mips-fixes.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2023-09-25 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 7:06 [PATCH] MIPS: Alchemy: only build mmc support helpers if au1xmmc is enabled Christoph Hellwig
2023-09-06 1:04 ` Randy Dunlap
2023-09-08 8:16 ` Christoph Hellwig
2023-09-08 13:41 ` Thomas Bogendoerfer
2023-09-25 10:43 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRFkVy3kBytSC5y8@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=arnd@arndb.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lkp@intel.com \
--cc=manuel.lauss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox