* Re: [PATCH v2 1/1] staging: speakup: Remove repeated word in comments
2023-09-25 5:45 [PATCH v2 1/1] staging: speakup: Remove repeated word in comments huangli05
@ 2023-09-26 1:05 ` Bagas Sanjaya
0 siblings, 0 replies; 2+ messages in thread
From: Bagas Sanjaya @ 2023-09-26 1:05 UTC (permalink / raw)
To: huangli05, Greg KH; +Cc: osmtendev, speakup, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2149 bytes --]
On Mon, Sep 25, 2023 at 01:45:59PM +0800, huangli05 wrote:
> Remove the repeated word "the" in comments.
>
> Signed-off-by: huangli05 <huangli05@inspur.com>
> ---
> drivers/accessibility/speakup/speakup_soft.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accessibility/speakup/speakup_soft.c b/drivers/accessibility/speakup/speakup_soft.c
> index 6d446824677b..6549bfb96e7f 100644
> --- a/drivers/accessibility/speakup/speakup_soft.c
> +++ b/drivers/accessibility/speakup/speakup_soft.c
> @@ -446,7 +446,7 @@ static int softsynth_adjust(struct spk_synth *synth, struct st_var_header *var)
> if (var->var_id != PUNC_LEVEL)
> return 0;
>
> - /* We want to set the the speech synthesis punctuation level
> + /* We want to set the speech synthesis punctuation level
> * accordingly, so it properly tunes speaking A_PUNC characters */
> var_data = var->data;
> if (!var_data)
You have not addressed Greg's patch email bot warnings from your v1 patch
yet [1], so I repeat it:
> - You did not specify a description of why the patch is needed, or
> possibly, any description at all, in the email body. Please read the
> section entitled "The canonical patch format" in the kernel file,
> Documentation/process/submitting-patches.rst for what is needed in
> order to properly describe the change.
>
> - You did not write a descriptive Subject: for the patch, allowing Greg,
> and everyone else, to know what this patch is all about. Please read
> the section entitled "The canonical patch format" in the kernel file,
> Documentation/process/submitting-patches.rst for what a proper
> Subject: line should look like.
>
> - It looks like you did not use your "real" name for the patch on either
> the Signed-off-by: line, or the From: line (both of which have to
> match). Please read the kernel file,
> Documentation/process/submitting-patches.rst for how to do this
> correctly.
Thanks.
[1]: https://lore.kernel.org/all/20230921021349.3350-1-huangli05@inspur.com/
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread