From: Paul Aurich <paul@darkrain42.org>
To: Steve French <smfrench@gmail.com>, Tom Talpey <tom@talpey.com>
Cc: Brian Pardy <brian.pardy@gmail.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Linux CIFS <linux-cifs@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Regressions <regressions@lists.linux.dev>,
Paulo Alcantara <pc@manguebit.com>,
ronnie sahlberg <ronniesahlberg@gmail.com>,
Shyam Prasad N <nspmangalore@gmail.com>,
Bharath S M <bharathsm@microsoft.com>
Subject: Re: Possible bug report: kernel 6.5.0/6.5.1 high load when CIFS share is mounted (cifsd-cfid-laundromat in"D" state)
Date: Tue, 26 Sep 2023 17:54:10 -0700 [thread overview]
Message-ID: <ZRN9MtBqYnT6oX60@vaarsuvius> (raw)
In-Reply-To: <CAH2r5mszCxPtdURenMVgeVDX5zc8knumH=ASXyUufPa7SxbJBw@mail.gmail.com>
On 2023-09-19 13:23:44 -0500, Steve French wrote:
>On Tue, Sep 19, 2023 at 1:07 PM Tom Talpey <tom@talpey.com> wrote:
>> These changes are good, but I'm skeptical they will reduce the load
>> when the laundromat thread is actually running. All these do is avoid
>> creating it when not necessary, right?
>
>It does create half as many laundromat threads (we don't need
>laundromat on connection to IPC$) even for the Windows server target
>example, but helps more for cases where server doesn't support
>directory leases.
Perhaps the laundromat thread should be using msleep_interruptible()?
Using an interruptible sleep appears to prevent the thread from contributing
to the load average, and has the happy side-effect of removing the up-to-1s delay
when tearing down the tcon (since a7c01fa93ae, kthread_stop() will return
early triggered by kthread_stop).
~Paul
next prev parent reply other threads:[~2023-09-27 1:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAO+kfxTwOvaxYV0ZRESxZB-4LHsF9b_VBjAKahhwUm5a1_c4ug@mail.gmail.com>
2023-09-06 1:01 ` Possible bug report: kernel 6.5.0/6.5.1 high load when CIFS share is mounted (cifsd-cfid-laundromat in"D" state) Bagas Sanjaya
2023-09-06 21:03 ` Brian Pardy
2023-09-07 3:40 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-09-18 22:55 ` Brian Pardy
2023-09-19 3:00 ` Steve French
2023-09-19 5:36 ` Steve French
2023-09-19 13:21 ` Brian Pardy
2023-09-19 16:38 ` Steve French
2023-09-19 17:42 ` Brian Pardy
2023-09-19 18:06 ` Tom Talpey
2023-09-19 18:23 ` Steve French
2023-09-27 0:54 ` Paul Aurich [this message]
2023-10-05 9:55 ` Dr. Bernd Feige
2023-10-05 9:59 ` Steve French
2023-10-13 23:19 ` matoro
2023-10-13 23:52 ` Paulo Alcantara
2023-10-14 0:01 ` Paulo Alcantara
[not found] ` <CAH2r5mse_2sfXF+tdTmie5LLtBuc+6DOumDH3rn=5V24yhrYVQ@mail.gmail.com>
2023-10-14 0:59 ` matoro
2023-10-16 18:41 ` Paulo Alcantara
2023-10-20 14:37 ` Dr. Bernd Feige
2023-10-23 14:07 ` Paulo Alcantara
2023-10-24 2:51 ` Steve French
2023-09-19 3:01 ` Steve French
2023-10-20 10:40 ` Linux regression tracking #update (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRN9MtBqYnT6oX60@vaarsuvius \
--to=paul@darkrain42.org \
--cc=bagasdotme@gmail.com \
--cc=bharathsm@microsoft.com \
--cc=brian.pardy@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=pc@manguebit.com \
--cc=regressions@lists.linux.dev \
--cc=ronniesahlberg@gmail.com \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox