From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Abdel Alkuor <alkuor@gmail.com>
Cc: krzysztof.kozlowski+dt@linaro.org, bryan.odonoghue@linaro.org,
gregkh@linuxfoundation.org, robh+dt@kernel.org,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, conor+dt@kernel.org,
ryan.eleceng@gmail.com
Subject: Re: [PATCH v6 02/14] USB: typec: Add cmd timeout and response delay
Date: Wed, 27 Sep 2023 10:00:45 +0300 [thread overview]
Message-ID: <ZRPTHeYhdtdtKZ1/@kuha.fi.intel.com> (raw)
In-Reply-To: <20230923073959.86660-3-alkuor@gmail.com>
On Sat, Sep 23, 2023 at 03:39:47AM -0400, Abdel Alkuor wrote:
> Some commands in tps25750 take longer than 1 second
> to complete, and some responses need some delay before
> the result becomes available.
>
> Signed-off-by: Abdel Alkuor <alkuor@gmail.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> Changes in v6:
> - Use tps6598x_exec_cmd as a wrapper
> Changes in v5:
> - Incorporating tps25750 into tps6598x driver
>
> drivers/usb/typec/tipd/core.c | 19 +++++++++++++++----
> 1 file changed, 15 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 37b56ce75f39..32420c61660d 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -282,9 +282,10 @@ static void tps6598x_disconnect(struct tps6598x *tps, u32 status)
> power_supply_changed(tps->psy);
> }
>
> -static int tps6598x_exec_cmd(struct tps6598x *tps, const char *cmd,
> +static int tps6598x_exec_cmd_tmo(struct tps6598x *tps, const char *cmd,
> size_t in_len, u8 *in_data,
> - size_t out_len, u8 *out_data)
> + size_t out_len, u8 *out_data,
> + u32 cmd_timeout_ms, u32 res_delay_ms)
> {
> unsigned long timeout;
> u32 val;
> @@ -307,8 +308,7 @@ static int tps6598x_exec_cmd(struct tps6598x *tps, const char *cmd,
> if (ret < 0)
> return ret;
>
> - /* XXX: Using 1s for now, but it may not be enough for every command. */
> - timeout = jiffies + msecs_to_jiffies(1000);
> + timeout = jiffies + msecs_to_jiffies(cmd_timeout_ms);
>
> do {
> ret = tps6598x_read32(tps, TPS_REG_CMD1, &val);
> @@ -321,6 +321,9 @@ static int tps6598x_exec_cmd(struct tps6598x *tps, const char *cmd,
> return -ETIMEDOUT;
> } while (val);
>
> + /* some commands require delay for the result to be available */
> + mdelay(res_delay_ms);
> +
> if (out_len) {
> ret = tps6598x_block_read(tps, TPS_REG_DATA1,
> out_data, out_len);
> @@ -345,6 +348,14 @@ static int tps6598x_exec_cmd(struct tps6598x *tps, const char *cmd,
> return 0;
> }
>
> +static int tps6598x_exec_cmd(struct tps6598x *tps, const char *cmd,
> + size_t in_len, u8 *in_data,
> + size_t out_len, u8 *out_data)
> +{
> + return tps6598x_exec_cmd_tmo(tps, cmd, in_len, in_data,
> + out_len, out_data, 1000, 0);
> +}
> +
> static int tps6598x_dr_set(struct typec_port *port, enum typec_data_role role)
> {
> const char *cmd = (role == TYPEC_DEVICE) ? "SWUF" : "SWDF";
> --
> 2.34.1
--
heikki
next prev parent reply other threads:[~2023-09-27 7:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 7:39 [PATCH v6 00/14] Add TPS25750 USB type-C PD controller support Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 01/14] dt-bindings: usb: tps6598x: Add tps25750 Abdel Alkuor
2023-09-23 11:49 ` Krzysztof Kozlowski
2023-09-23 7:39 ` [PATCH v6 02/14] USB: typec: Add cmd timeout and response delay Abdel Alkuor
2023-09-27 7:00 ` Heikki Krogerus [this message]
2023-09-27 7:18 ` Heikki Krogerus
2023-09-27 7:47 ` Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 03/14] USB: typec: Add patch mode to tps6598x Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 04/14] USB: typec: Load TPS25750 patch bundle Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 05/14] USB: typec: Check for EEPROM present Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 06/14] USB: typec: Clear dead battery flag Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 07/14] USB: typec: Apply patch again after power resume Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 08/14] USB: typec: Add interrupt support for TPS25750 Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 09/14] USB: typec: Refactor tps6598x port registration Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 10/14] USB: typec: Add port registration for tps25750 Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 11/14] USB: typec: Enable sleep mode " Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 12/14] USB: typec: Add trace for tps25750 irq Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 13/14] USB: typec: Add power status trace for tps25750 Abdel Alkuor
2023-09-23 7:39 ` [PATCH v6 14/14] USB: typec: Add " Abdel Alkuor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRPTHeYhdtdtKZ1/@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=alkuor@gmail.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ryan.eleceng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox