public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: xin@zytor.com
Cc: linux-kernel@vger.kernel.org, luto@kernel.org,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com
Subject: Re: [PATCH 1/1] x86/entry: remove unused argument %rsi passed to exc_nmi()
Date: Wed, 27 Sep 2023 10:06:23 +0200	[thread overview]
Message-ID: <ZRPif+9R8pp1v+m1@gmail.com> (raw)
In-Reply-To: <20230926061319.1929127-1-xin@zytor.com>


* xin@zytor.com <xin@zytor.com> wrote:

> From: "Xin Li (Intel)" <xin@zytor.com>
> 
> exc_nmi() only takes one argument of type struct pt_regs *, but
> asm_exc_nmi() calls it with 2 arguments. The second one passed
> in %rsi seems a leftover, so simply remove it.
> 
> BTW, fix 2 slips in the comments.
> 
> Signed-off-by: Xin Li (Intel) <xin@zytor.com>
> Acked-by: H. Peter Anvin (Intel) <hpa@zytor.com>
> ---
>  arch/x86/entry/entry_64.S | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)

I've split this into two patches, because the comment fixes
are entirely unrelated to this patch.

[ I've propagated the SOBs and Acked-by's to the two patches,
  as I presume is fine by everyone involved? ]

Thanks,

	Ingo

  reply	other threads:[~2023-09-27  8:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26  6:13 [PATCH 1/1] x86/entry: remove unused argument %rsi passed to exc_nmi() xin
2023-09-27  8:06 ` Ingo Molnar [this message]
2023-09-27  8:12   ` Xin Li
2023-09-27 19:15   ` H. Peter Anvin
2023-09-27  8:11 ` [tip: x86/asm] x86/entry: Remove " tip-bot2 for Xin Li (Intel)
2023-09-27  8:11 ` [tip: x86/asm] x86/entry: Fix typos in comments tip-bot2 for Xin Li (Intel)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZRPif+9R8pp1v+m1@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xin@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox