From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34257E810A2 for ; Wed, 27 Sep 2023 08:06:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230108AbjI0IGe (ORCPT ); Wed, 27 Sep 2023 04:06:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230193AbjI0IGa (ORCPT ); Wed, 27 Sep 2023 04:06:30 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BC5D1AA for ; Wed, 27 Sep 2023 01:06:28 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-98377c5d53eso1286586066b.0 for ; Wed, 27 Sep 2023 01:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695801986; x=1696406786; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=ryydy9ohdDMnk3LeSCYYGEmNVUaQ5qBDaUQrrGSDq5Y=; b=RPiooq35ermSJ99aYG07xTo/i4OeCSCEt3DStTbX1S4B9AutmQqddqfn6ShZuW0OGF F/+fKeoPeflbCs8NQ3uMrVNpqx2Q5zE54l91Ym3CETKHPgBm/JCUZKBiDfN1xYShI6t6 q2CJ75pbE76irORD1zFHg7yse0zT/rNwjw1xQVskEt6t8NboEe+98Jej+DdcsPDycn4g 49I4RCbiD4u/cTwP/u5FIpxnlHG3XrxA0ABJj3gU2kEuWtZlyWdl/RYkgr75+glSX6e3 UOVUY5Y/v0Bu6JI6ggsQXbLycvAlqC4/YNbtZPlQW1nRr6GK2qnA+uYbv7TwYa77QCu6 SJnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695801986; x=1696406786; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ryydy9ohdDMnk3LeSCYYGEmNVUaQ5qBDaUQrrGSDq5Y=; b=p25mjEwv/pD0AnWKgadaNaFTtO8eRuMvok+6iy0dB+z4nZ/4afOnG70UxyFpATjNRU wt4KI3AJO/TUKYHInhiqHg6IF1xrN/K+diLCsctJtxyE8PkMT4CGQzoXzoAIvRcmSaTH dCtqP/qKCK3NZofV6DRTOLnagF7bglGGdc7gJQ1LqV2zpSG4NHLxrjg3g86BX1UUy/Jy 3OEiHHLglYbtMX0Bh3BhGsYVx14EggQ2+Nq6+IItQvYqHCVBKSzCehotKg0SvHQtxnOw sooYeZ5oOiFrBfT4aX3ro3HYWT+D2rYBc0HakDmV3EgZ78USEJFwb5SBn50UTlWQX4w+ kRtg== X-Gm-Message-State: AOJu0Yz/rwSCxfIoSYtv+mmkngyRSp2jpGniTPOvZqlrnzKTnhofJBN1 4p1uaz/jvQsLvFSmDDhWPR0= X-Google-Smtp-Source: AGHT+IGaiQTioYJMm8lqlrjKYYAOFXPwurpySherulz6mD8S5yL8sh1E66YUP1aQ3ifPsZql78lG/Q== X-Received: by 2002:a17:906:1017:b0:9ae:65a5:b6f4 with SMTP id 23-20020a170906101700b009ae65a5b6f4mr991625ejm.20.1695801986210; Wed, 27 Sep 2023 01:06:26 -0700 (PDT) Received: from gmail.com (1F2EF49C.nat.pool.telekom.hu. [31.46.244.156]) by smtp.gmail.com with ESMTPSA id md1-20020a170906ae8100b009ad8acac02asm8948524ejb.172.2023.09.27.01.06.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 01:06:25 -0700 (PDT) Sender: Ingo Molnar Date: Wed, 27 Sep 2023 10:06:23 +0200 From: Ingo Molnar To: xin@zytor.com Cc: linux-kernel@vger.kernel.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com Subject: Re: [PATCH 1/1] x86/entry: remove unused argument %rsi passed to exc_nmi() Message-ID: References: <20230926061319.1929127-1-xin@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230926061319.1929127-1-xin@zytor.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * xin@zytor.com wrote: > From: "Xin Li (Intel)" > > exc_nmi() only takes one argument of type struct pt_regs *, but > asm_exc_nmi() calls it with 2 arguments. The second one passed > in %rsi seems a leftover, so simply remove it. > > BTW, fix 2 slips in the comments. > > Signed-off-by: Xin Li (Intel) > Acked-by: H. Peter Anvin (Intel) > --- > arch/x86/entry/entry_64.S | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) I've split this into two patches, because the comment fixes are entirely unrelated to this patch. [ I've propagated the SOBs and Acked-by's to the two patches, as I presume is fine by everyone involved? ] Thanks, Ingo