Re: [RFC 1/2] dt-bindings: iio: imu: Add DT binding doc for BMI323

Jagath Jog J
2023-09-27T21:37:39Z

HI Jonathan,

On Sun, Sep 24, 2023 at 7:07 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Mon, 18 Sep 2023 13:33:13 +0530
> Jagath Jog J <jagathjog1996@gmail.com> wrote:
>
> > Add devicetree description document for Bosch BMI323, a 6-Axis IMU.
> >
> > Signed-off-by: Jagath Jog J <jagathjog1996@gmail.com>
> > ---
> > .../bindings/iio/imu/bosch,bmi323.yaml | 81 +++++++++++++++++++
> > 1 file changed, 81 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/imu/bosch,bmi323.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,bmi323.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,bmi323.yaml
> > new file mode 100644
> > index 000000000000..9c08988103c5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/imu/bosch,bmi323.yaml
> > @@ -0,0 +1,81 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/imu/bosch,bmi323.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Bosch BMI323 6-Axis IMU
> > +
> > +maintainers:
> > + - Jagath Jog J <jagathjog1996@gmail.com>
> > +
> > +description:
> > + BMI323 is a 6-axis inertial measurement unit that supports acceleration and
> > + gyroscopic measurements with hardware fifo buffering. Sensor also provides
> > + events information such as motion, steps, orientation, single and double
> > + tap detection.
> > +
> > +properties:
> > + compatible:
> > + const: bosch,bmi323
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + interrupt-names:
> > + enum:
> > + - INT1
> > + - INT2
> > + description: |
> > + set to "INT1" if INT1 pin should be used as interrupt input, set
> > + to "INT2" if INT2 pin should be used instead
>
> Why not both? Sure driver might elect to use only one, but the binding
> describes the hardware not the driver and both might be wired.

If both interrupt pins are wired, should the DTS file need to define
both of the pins?

>
> Lots of different sources of interrupts so might be advantageous
> to split them up across two wires. A simple case being to route
> errors to one and everything 'good' to the other. No obligation to
> support that in the Linux driver though if you don't need to.

Sure I will split into two different wires in bindings.

>
> > +
> > + drive-open-drain:
> > + description: |
> > + set if the specified interrupt pin should be configured as
> > + open drain. If not set, defaults to push-pull.
>
> Two pins. Might be different so you need two controls.

Sure, In bindings I will add two different drive controls.
If both interrupt pins are wired with different drive options
should the DTS file still define both of the pins?

>
> > +
> > +required:
> > + - compatible
> > + - reg
>
> As mentioned, need power supplies specified and marked as required
> (though they may be provided via always on regulators and rely on stubs
> being created by the regulator subsystem on a given board).
> Looks like there are at least 2 supplies.

Sure, I will add 2 power supplies in the next series.

Regards
Jagath