Re: [PATCH 1/3] bootmem: use kmemleak_free_part_phys in free_bootmem_page/put_page_bootmem

Andrew Morton
2023-09-27T16:05:11Z

On Wed, 27 Sep 2023 11:59:21 +0800 Liu Shixin <liushixin2@huawei.com> wrote:

> Since kmemleak_alloc_phys() rather than kmemleak_alloc() was called from
> memblock_alloc_range_nid(), kmemleak_free_part_phys() should be used to
> delete kmemleak object in free_bootmem_page() and put_page_bootmem().
>
> Fixes: 028725e73375 ("bootmem: remove the vmemmap pages from kmemleak in free_bootmem_page")
> Fixes: dd0ff4d12dd2 ("bootmem: remove the vmemmap pages from kmemleak in put_page_bootmem")

Having two Fixes: is awkward. If someone is considering backporting
this patch into earlier kernels then which Fixes: target should they
use to decide whether the fix is applicable?

So I think it would be best if this patch was split into two patches,
please.

And let's decide whther these fixes should be backported into -stable
kernels. For that, please alter the changelogs so they tell us what are
the userspace-visible effect of the bugs.