From: Wolfram Sang <wsa@kernel.org>
To: "William A. Kennington III" <william@wkennington.com>
Cc: tmaimon77@gmail.com, tali.perry1@gmail.com,
avifishman70@gmail.com, joel@jms.id.au,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: npcm7xx: Fix callback completion ordering
Date: Wed, 27 Sep 2023 21:31:49 +0200 [thread overview]
Message-ID: <ZRSDJc8NlVkRvp5Z@shikoro> (raw)
In-Reply-To: <20230924010214.3700150-1-william@wkennington.com>
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
On Sat, Sep 23, 2023 at 06:02:14PM -0700, William A. Kennington III wrote:
> Sometimes, our completions race with new master transfers and override
> the bus->operation and bus->master_or_slave variables. This causes
> transactions to timeout and kernel crashes less frequently.
>
> To remedy this, we re-order all completions to the very end of the
> function.
>
> Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver")
> Signed-off-by: William A. Kennington III <william@wkennington.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-09-27 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 1:02 [PATCH] i2c: npcm7xx: Fix callback completion ordering William A. Kennington III
2023-09-26 5:41 ` Tali Perry
2023-09-27 19:31 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRSDJc8NlVkRvp5Z@shikoro \
--to=wsa@kernel.org \
--cc=avifishman70@gmail.com \
--cc=joel@jms.id.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=william@wkennington.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox