From: Ingo Molnar <mingo@kernel.org>
To: Marc Zyngier <maz@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Biju Das <biju.das.jz@bp.renesas.com>,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Maulik Shah <quic_mkshah@quicinc.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] irqchip fixes for 6.6, take #1
Date: Thu, 28 Sep 2023 23:17:23 +0200 [thread overview]
Message-ID: <ZRXtYzIA5dK1iPVb@gmail.com> (raw)
In-Reply-To: <20230924094105.2361754-1-maz@kernel.org>
* Marc Zyngier <maz@kernel.org> wrote:
> Dmitry Baryshkov (1):
> arm64: dts: qcom: sm8150: extend the size of the PDC resource
This SOB chain, while valid, is a hodgepodge with no rhyme and reason:
Fixes: 397ad94668c1 ("arm64: dts: qcom: sm8150: Add pdc interrupt controller node")
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20230905-topic-sm8x50-upstream-pdc-ver-v4-2-fc633c7df84b@linaro.org
Besides the ordering, people in the SOB chain should not have a separate
Reviewed-by tag: *of course* anyone who forwards a patch with a SOB has
reviewed it, it's basically implicit.
So the tags should be something like:
Fixes: 397ad94668c1 ("arm64: dts: qcom: sm8150: Add pdc interrupt controller node")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20230905-topic-sm8x50-upstream-pdc-ver-v4-2-fc633c7df84b@linaro.org
Ie. we generally sort the tags not chronologically (or whatever the original idea
was), but group them topically, sort the groups by importance, and only within
the group is there chronological order.
Thanks,
Ingo
next prev parent reply other threads:[~2023-09-28 21:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 9:41 [GIT PULL] irqchip fixes for 6.6, take #1 Marc Zyngier
2023-09-28 21:10 ` [tip: irq/urgent] Merge tag 'irqchip-fixes-6.6-1' of git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms into irq/urgent tip-bot2 for Thomas Gleixner
2023-09-28 21:12 ` [GIT PULL] irqchip fixes for 6.6, take #1 Ingo Molnar
2023-09-28 21:17 ` Ingo Molnar [this message]
2023-09-29 12:31 ` Geert Uytterhoeven
2023-09-29 21:05 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRXtYzIA5dK1iPVb@gmail.com \
--to=mingo@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=geert+renesas@glider.be \
--cc=konrad.dybcio@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=quic_mkshah@quicinc.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox