[GIT PULL] irqchip fixes for 6.6, take #1

[GIT PULL] irqchip fixes for 6.6, take #1

[Marc Zyngier]

Hi Thomas,

Here's the first cut of irqchip fixes that have graced my Inbox.
The most interesting thing is the fix for some Qualcomm HW, which
has a workaround for broken device trees that do not correctly
describe the hardware. The rest is a couple of fixes for the
Renesas RZG2L irqchip.

Please pull,

	M.

The following changes since commit 0bb80ecc33a8fb5a682236443c1e740d5c917d1d:

  Linux 6.6-rc1 (2023-09-10 16:28:41 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git tags/irqchip-fixes-6.6-1

for you to fetch changes up to 9b8df572ba3f4e544366196820a719a40774433e:

  irqchip: renesas-rzg2l: Fix logic to clear TINT interrupt source (2023-09-24 10:18:19 +0100)

----------------------------------------------------------------
irqchip fixes for 6.6, take #1

- Fix QC PDC v3.2 support by working around broken firmware tables

- Fix rzg2l-irqc missing #interrupt-cells description in the DT binding

- Fix rzg2l-irqc interrupt masking

----------------------------------------------------------------
Biju Das (1):
      irqchip: renesas-rzg2l: Fix logic to clear TINT interrupt source

Dmitry Baryshkov (1):
      arm64: dts: qcom: sm8150: extend the size of the PDC resource

Lad Prabhakar (1):
      dt-bindings: interrupt-controller: renesas,rzg2l-irqc: Update description for '#interrupt-cells' property

Neil Armstrong (1):
      irqchip/qcom-pdc: Add support for v3.2 HW

 .../interrupt-controller/renesas,rzg2l-irqc.yaml   |  5 +-
 arch/arm64/boot/dts/qcom/sm8150.dtsi               |  2 +-
 drivers/irqchip/irq-renesas-rzg2l.c                |  2 +-
 drivers/irqchip/qcom-pdc.c                         | 69 ++++++++++++++++------
 4 files changed, 56 insertions(+), 22 deletions(-)

[tip: irq/urgent] Merge tag 'irqchip-fixes-6.6-1' of git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms into irq/urgent

[tip-bot2 for Thomas Gleixner]

The following commit has been merged into the irq/urgent branch of tip:

Commit-ID:     9cd847ee4d64c10b52f26f18d19eb6462ba7d2fe
Gitweb:        https://git.kernel.org/tip/9cd847ee4d64c10b52f26f18d19eb6462ba7d2fe
Author:        Thomas Gleixner <tglx@linutronix.de>
AuthorDate:    Thu, 28 Sep 2023 23:04:13 +02:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Thu, 28 Sep 2023 23:04:13 +02:00

Merge tag 'irqchip-fixes-6.6-1' of git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms into irq/urgent

Pull irqchip fixes from Marc Zygnier:

  - Fix QC PDC v3.2 support by working around broken firmware tables

  - Fix rzg2l-irqc missing #interrupt-cells description in the DT binding

  - Fix rzg2l-irqc interrupt masking

Link: https://lore.kernel.org/lkml/20230924094105.2361754-1-maz@kernel.org
---

Re: [GIT PULL] irqchip fixes for 6.6, take #1

[Ingo Molnar]

* Marc Zyngier <maz@kernel.org> wrote:

> Neil Armstrong (1):
>       irqchip/qcom-pdc: Add support for v3.2 HW

This commit has a broken SOB chain:

  From: Neil Armstrong <neil.armstrong@linaro.org>
  Date: Tue, 5 Sep 2023 15:19:25 +0200
  Subject: [PATCH] irqchip/qcom-pdc: Add support for v3.2 HW

  ...

  Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Reviewed-by: Maulik Shah <quic_mkshah@quicinc.com>
  Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
  Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
  Signed-off-by: Marc Zyngier <maz@kernel.org>

The first SOB (Dmitry Baryshkov) is not the author (Neil Armstrong).

Also, please group SOBs together, as is the usual core kernel style.

Thanks,

	Ingo

Re: [GIT PULL] irqchip fixes for 6.6, take #1

[Ingo Molnar]

* Marc Zyngier <maz@kernel.org> wrote:

> Dmitry Baryshkov (1):
>       arm64: dts: qcom: sm8150: extend the size of the PDC resource

This SOB chain, while valid, is a hodgepodge with no rhyme and reason:

  Fixes: 397ad94668c1 ("arm64: dts: qcom: sm8150: Add pdc interrupt controller node")
  Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
  Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
  Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
  Signed-off-by: Marc Zyngier <maz@kernel.org>
  Link: https://lore.kernel.org/r/20230905-topic-sm8x50-upstream-pdc-ver-v4-2-fc633c7df84b@linaro.org

Besides the ordering, people in the SOB chain should not have a separate
Reviewed-by tag: *of course* anyone who forwards a patch with a SOB has
reviewed it, it's basically implicit.

So the tags should be something like:

  Fixes: 397ad94668c1 ("arm64: dts: qcom: sm8150: Add pdc interrupt controller node")
  Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
  Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
  Signed-off-by: Marc Zyngier <maz@kernel.org>
  Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
  Link: https://lore.kernel.org/r/20230905-topic-sm8x50-upstream-pdc-ver-v4-2-fc633c7df84b@linaro.org

Ie. we generally sort the tags not chronologically (or whatever the original idea
was), but group them topically, sort the groups by importance, and only within
the group is there chronological order.

Thanks,

	Ingo

Re: [GIT PULL] irqchip fixes for 6.6, take #1

[Geert Uytterhoeven]

Hi Ingo,

On Thu, Sep 28, 2023 at 11:17 PM Ingo Molnar <mingo@kernel.org> wrote:
> So the tags should be something like:
>
>   Fixes: 397ad94668c1 ("arm64: dts: qcom: sm8150: Add pdc interrupt controller node")
>   Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>   Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>   Signed-off-by: Marc Zyngier <maz@kernel.org>
>   Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>   Link: https://lore.kernel.org/r/20230905-topic-sm8x50-upstream-pdc-ver-v4-2-fc633c7df84b@linaro.org
>
> Ie. we generally sort the tags not chronologically (or whatever the original idea
> was), but group them topically, sort the groups by importance, and only within
> the group is there chronological order.

The tags should represent the order of the hand-off chain:

https://elixir.bootlin.com/linux/v6.6-rc1/source/Documentation/process/submitting-patches.rst#L449

and chronological history:

https://elixir.bootlin.com/linux/v6.6-rc1/source/Documentation/process/submitting-patches.rst#L493

Although current b4 seems to move tags around sometimes...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [GIT PULL] irqchip fixes for 6.6, take #1

[Ingo Molnar]

* Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> Hi Ingo,
> 
> On Thu, Sep 28, 2023 at 11:17 PM Ingo Molnar <mingo@kernel.org> wrote:
> > So the tags should be something like:
> >
> >   Fixes: 397ad94668c1 ("arm64: dts: qcom: sm8150: Add pdc interrupt controller node")
> >   Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> >   Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> >   Signed-off-by: Marc Zyngier <maz@kernel.org>
> >   Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> >   Link: https://lore.kernel.org/r/20230905-topic-sm8x50-upstream-pdc-ver-v4-2-fc633c7df84b@linaro.org
> >
> > Ie. we generally sort the tags not chronologically (or whatever the original idea
> > was), but group them topically, sort the groups by importance, and only within
> > the group is there chronological order.
> 
> The tags should represent the order of the hand-off chain:
> 
> https://elixir.bootlin.com/linux/v6.6-rc1/source/Documentation/process/submitting-patches.rst#L449
> 
> and chronological history:
> 
> https://elixir.bootlin.com/linux/v6.6-rc1/source/Documentation/process/submitting-patches.rst#L493

That chronological requirement is only for the SOB chain itself.

To quote Documentation/process/submitting-patches.rst:

     Standard sign-off procedure applies, i.e. the ordering of Signed-off-by: tags should 
     reflect the chronological history of the patch insofar as possible,

which is exactly what I wrote above:

> > > only within the group is there chronological order.
      ^^^^^^^^^^^^^^^^^^^^^

In fact it would be crazy to require that all the tags are chronological,
in the random  order they arrived, which the commits I pointed out appeared to be.

Thanks,

	Ingo