* [PATCH] psi: update psi irqtime when the irq delta is nozero
@ 2023-08-10 13:15 Lu Jialin
2023-08-11 6:43 ` Chengming Zhou
2023-09-28 21:26 ` Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Lu Jialin @ 2023-08-10 13:15 UTC (permalink / raw)
To: Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot,
Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Daniel Bristot de Oliveira, Valentin Schneider
Cc: Lu Jialin, linux-kernel
If update psi irqtime whether the irq delta is zero or not, the performance
will be degradation when update_rq_clock_task works frequently.
Therefore, just update psi irqtime whether the irq delta is nozero.
performace test of times(libmicro):
1) without psi_account_irqtime in update_rq_clock_task
[root@arm64_perf]# ./times -E -C 200 -L -S -W -N "times" -I 200
Running: times# ./../bin-arm64/times -E -C 200 -L -S -W -N times -I 200
prc thr usecs/call samples errors cnt/samp
times 1 1 0.45210 188 0 500
2) psi_account_irqtime in update_rq_clock_task
[root@arm64_perf]# ./times -E -C 200 -L -S -W -N "times" -I 200
Running: times# ./../bin-arm64/times -E -C 200 -L -S -W -N times -I 200
prc thr usecs/call samples errors cnt/samp
times 1 1 0.49408 196 0 500
3) psi_account_irqtime in update_rq_clock_task when irq delta is nozero
[root@arm64_perf]# ./times -E -C 200 -L -S -W -N "times" -I 200
Running: times# ./../bin-arm64/times -E -C 200 -L -S -W -N times -I 200
prc thr usecs/call samples errors cnt/samp
times 1 1 0.45158 195 0 500
Signed-off-by: Lu Jialin <lujialin4@huawei.com>
---
kernel/sched/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index c52c2eba7c73..69c4f229d6d1 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -722,7 +722,8 @@ static void update_rq_clock_task(struct rq *rq, s64 delta)
rq->prev_irq_time += irq_delta;
delta -= irq_delta;
- psi_account_irqtime(rq->curr, irq_delta);
+ if (irq_delta)
+ psi_account_irqtime(rq->curr, irq_delta);
delayacct_irq(rq->curr, irq_delta);
#endif
#ifdef CONFIG_PARAVIRT_TIME_ACCOUNTING
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] psi: update psi irqtime when the irq delta is nozero
2023-08-10 13:15 [PATCH] psi: update psi irqtime when the irq delta is nozero Lu Jialin
@ 2023-08-11 6:43 ` Chengming Zhou
2023-09-28 21:26 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Chengming Zhou @ 2023-08-11 6:43 UTC (permalink / raw)
To: Lu Jialin
Cc: linux-kernel, Ingo Molnar, Peter Zijlstra, Juri Lelli,
Vincent Guittot, Dietmar Eggemann, Steven Rostedt, Mel Gorman,
Ben Segall, Daniel Bristot de Oliveira, Valentin Schneider
On 2023/8/10 21:15, Lu Jialin wrote:
> If update psi irqtime whether the irq delta is zero or not, the performance
> will be degradation when update_rq_clock_task works frequently.
> Therefore, just update psi irqtime whether the irq delta is nozero.
> performace test of times(libmicro):
> 1) without psi_account_irqtime in update_rq_clock_task
> [root@arm64_perf]# ./times -E -C 200 -L -S -W -N "times" -I 200
> Running: times# ./../bin-arm64/times -E -C 200 -L -S -W -N times -I 200
> prc thr usecs/call samples errors cnt/samp
> times 1 1 0.45210 188 0 500
>
> 2) psi_account_irqtime in update_rq_clock_task
> [root@arm64_perf]# ./times -E -C 200 -L -S -W -N "times" -I 200
> Running: times# ./../bin-arm64/times -E -C 200 -L -S -W -N times -I 200
> prc thr usecs/call samples errors cnt/samp
> times 1 1 0.49408 196 0 500
>
> 3) psi_account_irqtime in update_rq_clock_task when irq delta is nozero
> [root@arm64_perf]# ./times -E -C 200 -L -S -W -N "times" -I 200
> Running: times# ./../bin-arm64/times -E -C 200 -L -S -W -N times -I 200
> prc thr usecs/call samples errors cnt/samp
> times 1 1 0.45158 195 0 500
>
> Signed-off-by: Lu Jialin <lujialin4@huawei.com>
> ---
> kernel/sched/core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index c52c2eba7c73..69c4f229d6d1 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -722,7 +722,8 @@ static void update_rq_clock_task(struct rq *rq, s64 delta)
>
> rq->prev_irq_time += irq_delta;
> delta -= irq_delta;
> - psi_account_irqtime(rq->curr, irq_delta);
> + if (irq_delta)
> + psi_account_irqtime(rq->curr, irq_delta);
> delayacct_irq(rq->curr, irq_delta);
> #endif
> #ifdef CONFIG_PARAVIRT_TIME_ACCOUNTING
LGTM, thanks.
Reviewed-by: Chengming Zhou <zhouchengming@bytedance.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] psi: update psi irqtime when the irq delta is nozero
2023-08-10 13:15 [PATCH] psi: update psi irqtime when the irq delta is nozero Lu Jialin
2023-08-11 6:43 ` Chengming Zhou
@ 2023-09-28 21:26 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2023-09-28 21:26 UTC (permalink / raw)
To: Lu Jialin
Cc: Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot,
Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Daniel Bristot de Oliveira, Valentin Schneider, linux-kernel
* Lu Jialin <lujialin4@huawei.com> wrote:
> If update psi irqtime whether the irq delta is zero or not, the performance
> will be degradation when update_rq_clock_task works frequently.
> Therefore, just update psi irqtime whether the irq delta is nozero.
> performace test of times(libmicro):
> 1) without psi_account_irqtime in update_rq_clock_task
> [root@arm64_perf]# ./times -E -C 200 -L -S -W -N "times" -I 200
> Running: times# ./../bin-arm64/times -E -C 200 -L -S -W -N times -I 200
> prc thr usecs/call samples errors cnt/samp
> times 1 1 0.45210 188 0 500
>
> 2) psi_account_irqtime in update_rq_clock_task
> [root@arm64_perf]# ./times -E -C 200 -L -S -W -N "times" -I 200
> Running: times# ./../bin-arm64/times -E -C 200 -L -S -W -N times -I 200
> prc thr usecs/call samples errors cnt/samp
> times 1 1 0.49408 196 0 500
>
> 3) psi_account_irqtime in update_rq_clock_task when irq delta is nozero
> [root@arm64_perf]# ./times -E -C 200 -L -S -W -N "times" -I 200
> Running: times# ./../bin-arm64/times -E -C 200 -L -S -W -N times -I 200
> prc thr usecs/call samples errors cnt/samp
> times 1 1 0.45158 195 0 500
>
> Signed-off-by: Lu Jialin <lujialin4@huawei.com>
> ---
> kernel/sched/core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index c52c2eba7c73..69c4f229d6d1 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -722,7 +722,8 @@ static void update_rq_clock_task(struct rq *rq, s64 delta)
>
> rq->prev_irq_time += irq_delta;
> delta -= irq_delta;
> - psi_account_irqtime(rq->curr, irq_delta);
> + if (irq_delta)
> + psi_account_irqtime(rq->curr, irq_delta);
> delayacct_irq(rq->curr, irq_delta);
Erm, if irq_delta is zero, then a whole bunch of code around the place you
modified becomes NOP as well, right?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-28 21:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-10 13:15 [PATCH] psi: update psi irqtime when the irq delta is nozero Lu Jialin
2023-08-11 6:43 ` Chengming Zhou
2023-09-28 21:26 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox