From: Deepak R Varma <drv@mailo.com>
To: Bob Peterson <rpeterso@redhat.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
gfs2@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
Dan Carpenter <error27@gmail.com>, Deepak R Varma <drv@mailo.com>
Subject: [PATCH] gfs2: Set error on error path
Date: Fri, 29 Sep 2023 11:44:40 +0530 [thread overview]
Message-ID: <ZRZrUMzweaJeEJuD@runicha.com> (raw)
Set the error variable inside the error path on failure. Saves
unnecessary variable assignment during normal execution.
Signed-off-by: Deepak R Varma <drv@mailo.com>
---
fs/gfs2/bmap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
index ef7017fb6951..93bd8ea34444 100644
--- a/fs/gfs2/bmap.c
+++ b/fs/gfs2/bmap.c
@@ -162,9 +162,10 @@ int gfs2_unstuff_dinode(struct gfs2_inode *ip)
down_write(&ip->i_rw_mutex);
page = grab_cache_page(inode->i_mapping, 0);
- error = -ENOMEM;
- if (!page)
+ if (!page) {
+ error = -ENOMEM;
goto out;
+ }
error = __gfs2_unstuff_inode(ip, page);
unlock_page(page);
put_page(page);
--
2.39.2
next reply other threads:[~2023-09-29 6:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 6:14 Deepak R Varma [this message]
2023-09-29 7:14 ` [PATCH] gfs2: Set error on error path Dan Carpenter
2023-09-29 7:32 ` drv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRZrUMzweaJeEJuD@runicha.com \
--to=drv@mailo.com \
--cc=agruenba@redhat.com \
--cc=error27@gmail.com \
--cc=gfs2@lists.linux.dev \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox