* [PATCH] gfs2: Set error on error path
@ 2023-09-29 6:14 Deepak R Varma
2023-09-29 7:14 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Deepak R Varma @ 2023-09-29 6:14 UTC (permalink / raw)
To: Bob Peterson, Andreas Gruenbacher, gfs2, linux-kernel
Cc: linux-kernel-mentees, Dan Carpenter, Deepak R Varma
Set the error variable inside the error path on failure. Saves
unnecessary variable assignment during normal execution.
Signed-off-by: Deepak R Varma <drv@mailo.com>
---
fs/gfs2/bmap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
index ef7017fb6951..93bd8ea34444 100644
--- a/fs/gfs2/bmap.c
+++ b/fs/gfs2/bmap.c
@@ -162,9 +162,10 @@ int gfs2_unstuff_dinode(struct gfs2_inode *ip)
down_write(&ip->i_rw_mutex);
page = grab_cache_page(inode->i_mapping, 0);
- error = -ENOMEM;
- if (!page)
+ if (!page) {
+ error = -ENOMEM;
goto out;
+ }
error = __gfs2_unstuff_inode(ip, page);
unlock_page(page);
put_page(page);
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gfs2: Set error on error path
2023-09-29 6:14 [PATCH] gfs2: Set error on error path Deepak R Varma
@ 2023-09-29 7:14 ` Dan Carpenter
2023-09-29 7:32 ` drv
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2023-09-29 7:14 UTC (permalink / raw)
To: Deepak R Varma
Cc: Bob Peterson, Andreas Gruenbacher, gfs2, linux-kernel,
linux-kernel-mentees, Dan Carpenter
On Fri, Sep 29, 2023 at 11:44:40AM +0530, Deepak R Varma wrote:
> Set the error variable inside the error path on failure. Saves
> unnecessary variable assignment during normal execution.
>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
> fs/gfs2/bmap.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
> index ef7017fb6951..93bd8ea34444 100644
> --- a/fs/gfs2/bmap.c
> +++ b/fs/gfs2/bmap.c
> @@ -162,9 +162,10 @@ int gfs2_unstuff_dinode(struct gfs2_inode *ip)
>
> down_write(&ip->i_rw_mutex);
> page = grab_cache_page(inode->i_mapping, 0);
> - error = -ENOMEM;
> - if (!page)
> + if (!page) {
> + error = -ENOMEM;
> goto out;
> + }
It used to be that the other way was faster? I'm pretty sure the
compiler can figure it out these days. Please don't randomly start
changing people's prefered style unless it's drivers/staging/ code.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gfs2: Set error on error path
2023-09-29 7:14 ` Dan Carpenter
@ 2023-09-29 7:32 ` drv
0 siblings, 0 replies; 3+ messages in thread
From: drv @ 2023-09-29 7:32 UTC (permalink / raw)
To: Dan Carpenter
Cc: Bob Peterson, Andreas Gruenbacher, gfs2, linux-kernel,
linux-kernel-mentees, Dan Carpenter
On Fri, 2023-09-29 at 10:14 +0300, Dan Carpenter wrote:
> On Fri, Sep 29, 2023 at 11:44:40AM +0530, Deepak R Varma wrote:
> > Set the error variable inside the error path on failure. Saves
> > unnecessary variable assignment during normal execution.
> >
> > Signed-off-by: Deepak R Varma <drv@mailo.com>
> > ---
> > fs/gfs2/bmap.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c
> > index ef7017fb6951..93bd8ea34444 100644
> > --- a/fs/gfs2/bmap.c
> > +++ b/fs/gfs2/bmap.c
> > @@ -162,9 +162,10 @@ int gfs2_unstuff_dinode(struct gfs2_inode *ip)
> >
> > down_write(&ip->i_rw_mutex);
> > page = grab_cache_page(inode->i_mapping, 0);
> > - error = -ENOMEM;
> > - if (!page)
> > + if (!page) {
> > + error = -ENOMEM;
> > goto out;
> > + }
>
> It used to be that the other way was faster? I'm pretty sure the
> compiler can figure it out these days. Please don't randomly start
> changing people's prefered style unless it's drivers/staging/ code.
>
Hi Dan,
Thank you for the feedback. I did not know about the compiler
optimization resulting in original code being faster.
I will let the maintainers comment on breaking the style.
regards,
deepak.
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-29 7:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-29 6:14 [PATCH] gfs2: Set error on error path Deepak R Varma
2023-09-29 7:14 ` Dan Carpenter
2023-09-29 7:32 ` drv
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox