From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48BC4E7735F for ; Sat, 30 Sep 2023 16:52:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234584AbjI3Qwb (ORCPT ); Sat, 30 Sep 2023 12:52:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234586AbjI3Qw0 (ORCPT ); Sat, 30 Sep 2023 12:52:26 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C35CDE5 for ; Sat, 30 Sep 2023 09:52:22 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40652e570d9so28412565e9.1 for ; Sat, 30 Sep 2023 09:52:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20230601.gappssmtp.com; s=20230601; t=1696092741; x=1696697541; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TP49E0lt1lRfwVwEUZNQYaCBfTY4UGz9ptrNHBZhxcM=; b=GODHPJ5OBk5OFYXKYp/AsgCbEs96zHybKMqld2zYIYMA8bWsDO9CD32R4Ve892efWh Rw8h6Qoitfo9fDFRXeGZ1URS0UWu9IJBVx4Vya++BEVhXwx8iJTXEUg7vtyzXuhFlYS7 EaYP12e+2yYMGMjH/WAmkF/9TwNHyl/rOxe/+Raw1hFTZ4W/QiD6r+cTfVQujrg4ADiB t0EwhcgT/w1sqCgn4S5QesL/mVLbCPhL0Gs4zfmBWFR0O2+lvC4PwMCbZsvAUBYBpImL 7PoPTdEUlEjZSUqF5Cz+l5zBQwpp7snU3QkdNZzBDQG/BZuIT+Nwotv31hy32RoOfd+U mAYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696092741; x=1696697541; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TP49E0lt1lRfwVwEUZNQYaCBfTY4UGz9ptrNHBZhxcM=; b=r54hrp6wk1+VKa5TEdLeDadkxYe9xhFddATtJ5TPMZsH4QN67OXZA6LqsWWxl4ogdk dJbG5XCj0NfpsDtpF0qBr6voFwSG9Y8/AzTYFWG+bcNnFU/9I7XWG+clik/PxTvQNomH t8wUt0ExknJfsnoLMRDfYkBYe6lGDrDmVnp9ktUvsQitm43xtAfocCU9Fhb86dHgIfBa 955LsbR30SFFTcPyIOkaqOUBxApWkEY7eGQF/c15qXSkb0yLPu0Mdk0V2B3/3ezEFBvA Eo1NhzPtNPvj3vTDHCoOIibqqqbBuVCkULLDC7EaJtEozEvi/nj/ebFRNTHnCypJtQ71 avEg== X-Gm-Message-State: AOJu0Yw+DtpNl3KruowA/Mv+1VMpICsY5V0IjdQogUaH6M1vtjIUo3RG UQTfyGXipuimxw1eO/vi/9mB3g== X-Google-Smtp-Source: AGHT+IFufhUosQmDbdYYO0lgqH5WgmabRsKPy1NuiT6FdEpd1klh9Lx806UT3kRvn4yTyQ0Y4WLs9Q== X-Received: by 2002:adf:cf0a:0:b0:323:1689:6607 with SMTP id o10-20020adfcf0a000000b0032316896607mr6789063wrj.5.1696092741022; Sat, 30 Sep 2023 09:52:21 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id u1-20020adfed41000000b003247d3e5d99sm4921066wro.55.2023.09.30.09.52.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Sep 2023 09:52:20 -0700 (PDT) Date: Sat, 30 Sep 2023 17:52:17 +0100 From: Phillip Potter To: Joel Granados Cc: Luis Chamberlain , willy@infradead.org, josh@joshtriplett.org, Kees Cook , Clemens Ladisch , Arnd Bergmann , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jiri Slaby , "James E.J. Bottomley" , "Martin K. Petersen" , Doug Gilbert , Sudip Mukherjee , Jason Gunthorpe , Leon Romanovsky , Corey Minyard , Theodore Ts'o , "Jason A. Donenfeld" , David Ahern , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Robin Holt , Steve Wahl , Russ Weight , "Rafael J. Wysocki" , Song Liu , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-serial@vger.kernel.org, linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-rdma@vger.kernel.org, openipmi-developer@lists.sourceforge.net, netdev@vger.kernel.org, linux-raid@vger.kernel.org, linux-hyperv@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Greg Kroah-Hartman Subject: Re: [PATCH 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array Message-ID: References: <20230928-jag-sysctl_remove_empty_elem_drivers-v1-0-e59120fca9f9@samsung.com> <20230928-jag-sysctl_remove_empty_elem_drivers-v1-1-e59120fca9f9@samsung.com> <2023092855-cultivate-earthy-4d25@gregkh> <20230929121730.bwzhrpaptf45smfy@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230929121730.bwzhrpaptf45smfy@localhost> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 29, 2023 at 02:17:30PM +0200, Joel Granados wrote: > On Thu, Sep 28, 2023 at 03:36:55PM +0200, Greg Kroah-Hartman wrote: > > On Thu, Sep 28, 2023 at 03:21:26PM +0200, Joel Granados via B4 Relay wrote: > > > From: Joel Granados > > > > > > This commit comes at the tail end of a greater effort to remove the > > > empty elements at the end of the ctl_table arrays (sentinels) which > > > will reduce the overall build time size of the kernel and run time > > > memory bloat by ~64 bytes per sentinel (further information Link : > > > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/) > > > > > > Remove sentinel element from cdrom_table > > > > > > Signed-off-by: Joel Granados > > > --- > > > drivers/cdrom/cdrom.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c > > > index cc2839805983..451907ade389 100644 > > > --- a/drivers/cdrom/cdrom.c > > > +++ b/drivers/cdrom/cdrom.c > > > @@ -3654,8 +3654,7 @@ static struct ctl_table cdrom_table[] = { > > > .maxlen = sizeof(int), > > > .mode = 0644, > > > .proc_handler = cdrom_sysctl_handler > > > - }, > > > - { } > > > + } > > > > You should have the final entry as "}," so as to make any future > > additions to the list to only contain that entry, that's long been the > > kernel style for lists like this. > Will send a V2 with this included. Thx. > > > > > So your patches will just remove one line, not 2 and add 1, making it a > > smaller diff. > indeed. > > > > > thanks, > > > > greg k-h > > -- > > Joel Granados Hi Joel, Thank you for your patch. I look forward to seeing V2, and will be happy to review it. Regards, Phil