From: Ingo Molnar <mingo@kernel.org>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, vschneid@redhat.com,
linux-kernel@vger.kernel.org,
kernel test robot <oliver.sang@intel.com>
Subject: Re: [PATCH v4] sched/rt: move back to RT_GROUP_SCHED and rename it child
Date: Tue, 3 Oct 2023 11:51:47 +0200 [thread overview]
Message-ID: <ZRvkM1lxsTrHb2Ox@gmail.com> (raw)
In-Reply-To: <20230803050317.2240948-1-yajun.deng@linux.dev>
* Yajun Deng <yajun.deng@linux.dev> wrote:
> The member back in struct sched_rt_entity only related to RT_GROUP_SCHED,
> it should not place out of RT_GROUP_SCHED, move back to RT_GROUP_SCHED
> and rename it child.
>
> Init child when parent isn't NULL in init_tg_rt_entry().
>
> Introduce for_each_sched_rt_entity_reverse() to iterate rt_se from
> top to down.
>
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Closes: https://lore.kernel.org/oe-lkp/202308031034.4369b15b-oliver.sang@intel.com
Yeah, so I agree with these changes, but could you please split up this
patch into 3 separate patches:
sched/rt: Move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block
sched/rt: Rename sched_rt_entity::back to sched_rt_entity::child
sched/rt: Introduce for_each_sched_rt_entity_reverse() & use it
Thanks,
Ingo
next prev parent reply other threads:[~2023-10-03 9:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 5:03 [PATCH v4] sched/rt: move back to RT_GROUP_SCHED and rename it child Yajun Deng
2023-10-03 9:51 ` Ingo Molnar [this message]
2023-10-03 14:55 ` Yajun Deng
2023-10-03 16:37 ` Peter Zijlstra
2023-10-04 15:35 ` Yajun Deng
2023-10-03 10:36 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRvkM1lxsTrHb2Ox@gmail.com \
--to=mingo@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=oliver.sang@intel.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox