Re: [PATCH v12 15/37] x86/ptrace: Cleanup the definition of the pt_regs structure

Borislav Petkov
2023-11-28T08:37:09Z

On Mon, Oct 02, 2023 at 11:24:36PM -0700, Xin Li wrote:
> -/* Return frame for iretq */
> +
> + /* The IRETQ return frame starts here */
> unsigned long ip;
> - unsigned long cs;
> +
> + union {
> + u64 csx; // The full 64-bit data slot containing CS
> + u16 cs; // CS selector

I know people want to start using those // one-line comments now but
this struct already uses the /* multiline ones. Can we stick to one type
pls, otherwise it'll turn into a mess.

And pls put those comments ontop, not on the side.

Thx.

--
Regards/Gruss,
Boris.