From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CBC7CDB47E for ; Wed, 18 Oct 2023 11:35:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231308AbjJRLfD (ORCPT ); Wed, 18 Oct 2023 07:35:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231322AbjJRLe4 (ORCPT ); Wed, 18 Oct 2023 07:34:56 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1768A198 for ; Wed, 18 Oct 2023 04:34:49 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-9b2f73e3af3so1028606966b.3 for ; Wed, 18 Oct 2023 04:34:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697628887; x=1698233687; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=bLIYllS+O6Xd2qzawS5VK1eQ02CDGNfk+dIUUR4Mb9M=; b=cJFZs9KeWhc44wUobqG2sXmnLVs6/rwf2HA/ZuAiQ+cr20H7bdaq/4ioETFwkKW7bz PeMxsrPV/wUFDN4gn5KQxI8iRZQFtAJrwkyTL8flXwTqNiTNIqE19tdI8Bmen5DRJAtA nfkEICHwRgUUCi8GqPje5jxK+wkGxk+TFd810Uc0UQ3l2Sk0ll4lJUG2852p6/A4rGaW mLx2MphEYLX5+vLs1SViTgvaC10vC+08JXj5zU1JG32grA+WBT7lNn1xqG/yjBxrOGOY EMLzPudrOXcv2/wdcAfBGjt8dgNFZCuKVquHDSlY+hcdkpm/BPiDHVV2hJDPcfxA+RH5 IMYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697628887; x=1698233687; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bLIYllS+O6Xd2qzawS5VK1eQ02CDGNfk+dIUUR4Mb9M=; b=cN9LNuG0bipPws+YuCA3u8Ing5I5Pv5VyS/IDTMPfsTkPlQ6jmUNT/eVWVuKHHhS2q Qj1mvZyZG0qvD1Ti6AsdGPUOnsDjrUNWlF/jSNciSj5yjboXjsIHwO0sd0W0FqfTI78A n46v2SGgabdIjRw/eLEO+EiahIBS8AqfqlkBbz6+O4qv0T3pegavTO/VSbSD2oIoNPZ1 gP1yK10vVinCZ9AD7WwPgDzZU0wn9ZBhMGWp2Aip1+vu/6oN8H58atnD+tsF3pogVW21 szNb2EIN+K1zmf5Ioh/DIrX87x+USPTNw19HVFKsdaTbNrHpipk4Mbgex2BkuLMJkLV2 iH9A== X-Gm-Message-State: AOJu0YxT/NaLlJ6vyXCCC2Loq+XxEjVUrCtPK4JZkgp4ae569gjU62vD r3miUUqkzA4KC7xtyAEgg+g= X-Google-Smtp-Source: AGHT+IEYuZTECiTe/CWO5fzOqWJ8nMXo46EwDgNlRRBWZqPtxnbzqwj6YGcgm9HvKPNlFMhAV6hFaQ== X-Received: by 2002:a17:906:dac4:b0:9be:dce3:6e07 with SMTP id xi4-20020a170906dac400b009bedce36e07mr4461109ejb.32.1697628886950; Wed, 18 Oct 2023 04:34:46 -0700 (PDT) Received: from gmail.com (1F2EF7B2.nat.pool.telekom.hu. [31.46.247.178]) by smtp.gmail.com with ESMTPSA id mm27-20020a170906cc5b00b0099e12a49c8fsm1521281ejb.173.2023.10.18.04.34.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 04:34:46 -0700 (PDT) Sender: Ingo Molnar Date: Wed, 18 Oct 2023 13:34:44 +0200 From: Ingo Molnar To: Juergen Gross Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux-foundation.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Ajay Kaher , Alexey Makhalov , VMware PV-Drivers Reviewers Subject: Re: [PATCH v2 3/4] x86/paravirt: switch mixed paravirt/alternative calls to alternative_2 Message-ID: References: <20231016123933.17284-1-jgross@suse.com> <20231016123933.17284-4-jgross@suse.com> <20231016142930.GE33217@noisy.programming.kicks-ass.net> <4f5cc965-36da-43f0-aaaa-082a2235ec1e@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f5cc965-36da-43f0-aaaa-082a2235ec1e@suse.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Juergen Gross wrote: > On 16.10.23 16:29, Peter Zijlstra wrote: > > On Mon, Oct 16, 2023 at 02:39:32PM +0200, Juergen Gross wrote: > > > Instead of stacking alternative and paravirt patching, use the new > > > ALT_FLAG_CALL flag to switch those mixed calls to pure alternative > > > handling. > > > > > > This eliminates the need to be careful regarding the sequence of > > > alternative and paravirt patching. > > > > > > For call depth tracking callthunks_setup() needs to be adapted to patch > > > calls at alternative patching sites instead of paravirt calls. > > > > > > Signed-off-by: Juergen Gross > > > > I cannot help but feel this would've been better as two patches, one > > introducing ALT_NOT_XEN and then a second with the rest. > > In case I need to respin I'll split it up. Yeah, would be nice to split this patch into two, as Peter requested. Thanks, Ingo