public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicolinc@nvidia.com>
To: "Liu, Jingqi" <jingqi.liu@intel.com>
Cc: Yi Liu <yi.l.liu@intel.com>, <joro@8bytes.org>,
	<alex.williamson@redhat.com>, <jgg@nvidia.com>,
	<kevin.tian@intel.com>, <robin.murphy@arm.com>,
	<baolu.lu@linux.intel.com>, <cohuck@redhat.com>,
	<eric.auger@redhat.com>, <kvm@vger.kernel.org>,
	<mjrosato@linux.ibm.com>, <chao.p.peng@linux.intel.com>,
	<yi.y.sun@linux.intel.com>, <peterx@redhat.com>,
	<jasowang@redhat.com>, <shameerali.kolothum.thodi@huawei.com>,
	<lulu@redhat.com>, <suravee.suthikulpanit@amd.com>,
	<iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>, <zhenzhong.duan@intel.com>,
	<joao.m.martins@oracle.com>
Subject: Re: [PATCH v2 2/6] iommufd/hw_pagetable: Use domain_alloc_user op for domain allocation
Date: Mon, 16 Oct 2023 10:48:09 -0700	[thread overview]
Message-ID: <ZS13WVj4wpHeNeKP@Asurada-Nvidia> (raw)
In-Reply-To: <00163e5f-1a5a-a5c6-baa1-12b2a97e12b7@intel.com>

On Mon, Oct 16, 2023 at 04:16:05PM +0800, Liu, Jingqi wrote:
 
> @@ -88,10 +90,19 @@ iommufd_hw_pagetable_alloc(struct iommufd_ctx *ictx, struct iommufd_ioas *ioas,
>        refcount_inc(&ioas->obj.users);
>        hwpt->ioas = ioas;
> 
> -       hwpt->domain = iommu_domain_alloc(idev->dev->bus);
> -       if (!hwpt->domain) {
> -               rc = -ENOMEM;
> -               goto out_abort;
> +       if (ops->domain_alloc_user) {
> +               hwpt->domain = ops->domain_alloc_user(idev->dev, 0);
> 
> Seems a "flags" parameter needs to be passed to 'domain_alloc_user()'.
> Like this:
>         hwpt->domain = ops->domain_alloc_user(idev->dev, flags);

There's no "flags" parameter until the following PATCH-3:
https://lore.kernel.org/linux-iommu/20230928071528.26258-4-yi.l.liu@intel.com/

Thanks
Nicolin

  parent reply	other threads:[~2023-10-16 17:48 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-28  7:15 [PATCH v2 0/6] iommufd support allocating nested parent domain Yi Liu
2023-09-28  7:15 ` [PATCH v2 1/6] iommu: Add new iommu op to create domains owned by userspace Yi Liu
2023-10-09  1:09   ` Tian, Kevin
2023-10-15  7:14   ` Nicolin Chen
2023-10-16 12:04     ` Jason Gunthorpe
2023-10-16 17:46       ` Nicolin Chen
2023-10-17 16:05         ` Jason Gunthorpe
2023-09-28  7:15 ` [PATCH v2 2/6] iommufd/hw_pagetable: Use domain_alloc_user op for domain allocation Yi Liu
     [not found]   ` <00163e5f-1a5a-a5c6-baa1-12b2a97e12b7@intel.com>
2023-10-16 17:48     ` Nicolin Chen [this message]
2023-10-17  3:46       ` Liu, Jingqi
2023-09-28  7:15 ` [PATCH v2 3/6] iommufd/hw_pagetable: Accepts user flags " Yi Liu
2023-09-29  3:33   ` Baolu Lu
2023-09-28  7:15 ` [PATCH v2 4/6] iommufd/hw_pagetable: Support allocating nested parent domain Yi Liu
2023-09-29  3:34   ` Baolu Lu
2023-10-09  1:10   ` Tian, Kevin
2023-09-28  7:15 ` [PATCH v2 5/6] iommufd/selftest: Add domain_alloc_user() support in iommu mock Yi Liu
2023-10-09  1:12   ` Tian, Kevin
2023-09-28  7:15 ` [PATCH v2 6/6] iommu/vt-d: Add domain_alloc_user op Yi Liu
2023-09-29  3:38   ` Baolu Lu
2023-10-09  1:13   ` Tian, Kevin
2023-10-10 16:43   ` Jason Gunthorpe
2023-10-11  3:18     ` Baolu Lu
2023-10-10 16:47 ` [PATCH v2 0/6] iommufd support allocating nested parent domain Jason Gunthorpe
2023-10-12  7:33   ` Yi Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZS13WVj4wpHeNeKP@Asurada-Nvidia \
    --to=nicolinc@nvidia.com \
    --cc=alex.williamson@redhat.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=chao.p.peng@linux.intel.com \
    --cc=cohuck@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=iommu@lists.linux.dev \
    --cc=jasowang@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=jingqi.liu@intel.com \
    --cc=joao.m.martins@oracle.com \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lulu@redhat.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=peterx@redhat.com \
    --cc=robin.murphy@arm.com \
    --cc=shameerali.kolothum.thodi@huawei.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=yi.l.liu@intel.com \
    --cc=yi.y.sun@linux.intel.com \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox