From: Deepak R Varma <drv@mailo.com>
To: Huacai Chen <chenhuacai@kernel.org>
Cc: WANG Xuerui <kernel@xen0n.name>,
loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
Ira Weiny <ira.weiny@intel.com>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Subject: Re: kmap() transformation: Question about copy_user_highpage
Date: Sat, 7 Oct 2023 18:30:27 +0530 [thread overview]
Message-ID: <ZSFWa44FTi48hDyE@runicha.com> (raw)
In-Reply-To: <CAAhV-H7B2tqw-PWD2775Nx1JiPVwh8nGYsVDTiA0QjBhTYbrMw@mail.gmail.com>
On Sat, Oct 07, 2023 at 12:55:14PM +0800, Huacai Chen wrote:
> Hi, Deepak,
Hello Huacai,
>
> On Sat, Oct 7, 2023 at 2:46 AM Deepak R Varma <drv@mailo.com> wrote:
> >
> > Hello,
> > I am attempting to work on replacing the kmap[_atomic]() calls by
> > kmap_local_page() function call. A detail on this change can be found here [0].
> >
> > I would like to know if this function:
> > arch/loongarch/mm/init.c::copy_user_highpage()
> > is currently in use or is it a dead code?
> >
> > If this code is not in use, can this be removed instead? However, if it is in
> > use, can you comment why kmap_atomic() was preferred over kmap()
> > function call?
> I think this function will be used for the 32bit kernel, and we will
> add loongarch32 support in the near future.
Okay. Sounds good.
>
> But on the other hand, you can replace kmap_atomic() with
> kmap_local_page(), there is no special reason to use kmap_atomic().
Looks like you sent in a patch. Thank you. I was working on trying to cross
compile my patch for the arch. I still would like to attempt that. Will request
your help if I get stuck.
regards,
deepak.
>
> Huacai
>
> >
> > [0] https://lore.kernel.org/all/20201029222652.302358281@linutronix.de/
> >
> > Thank you,
> > Deepak.
> >
> >
> >
prev parent reply other threads:[~2023-10-07 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 18:46 kmap() transformation: Question about copy_user_highpage Deepak R Varma
2023-10-07 4:55 ` Huacai Chen
2023-10-07 13:00 ` Deepak R Varma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSFWa44FTi48hDyE@runicha.com \
--to=drv@mailo.com \
--cc=chenhuacai@kernel.org \
--cc=fmdefrancesco@gmail.com \
--cc=ira.weiny@intel.com \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox