Re: [PATCH] atm: fore200e: Drop unnecessary of_match_device()

Simon Horman
2023-10-09T13:19:57Z

On Fri, Oct 06, 2023 at 04:44:21PM -0500, Rob Herring wrote:
> It is not necessary to call of_match_device() in probe. If we made it to
> probe, then we've already successfully matched.
>
> Signed-off-by: Rob Herring <robh@kernel.org>

I agree that the check is redundant.
And that with it removed, the forward declaration of fore200e_sba_match
is no longer needed.

Minor nit: I assume the target tree is net-next.
Ideally that would be specified.

Subject: [PATCH net-net] ...

Reviewed-by: Simon Horman <horms@kernel.org>