public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
	vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
	bristot@redhat.com, vschneid@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] sched/rt: Move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block
Date: Mon, 9 Oct 2023 13:26:38 +0200	[thread overview]
Message-ID: <ZSPjbjPPMeafHbjU@gmail.com> (raw)
In-Reply-To: <5a3342ef-f14f-173c-630f-6b474bded257@linux.dev>


* Yajun Deng <yajun.deng@linux.dev> wrote:

> 
> On 2023/10/9 18:16, Ingo Molnar wrote:
> > * Yajun Deng <yajun.deng@linux.dev> wrote:
> > 
> > > The member back in struct sched_rt_entity only related to RT_GROUP_SCHED,
> > > So move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block. It
> > > will save a few bytes.
> > > 
> > > Also, init child when parent isn't NULL in init_tg_rt_entry().
> > > 
> > > Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> > > ---
> > >   include/linux/sched.h |  2 +-
> > >   kernel/sched/rt.c     | 18 +++++++++---------
> > >   2 files changed, 10 insertions(+), 10 deletions(-)
> > > 
> > > diff --git a/include/linux/sched.h b/include/linux/sched.h
> > > index 292c31697248..d0fe56603e60 100644
> > > --- a/include/linux/sched.h
> > > +++ b/include/linux/sched.h
> > > @@ -597,8 +597,8 @@ struct sched_rt_entity {
> > >   	unsigned short			on_rq;
> > >   	unsigned short			on_list;
> > > -	struct sched_rt_entity		*back;
> > >   #ifdef CONFIG_RT_GROUP_SCHED
> > > +	struct sched_rt_entity		*back;
> > >   	struct sched_rt_entity		*parent;
> > >   	/* rq on which this entity is (to be) queued: */
> > >   	struct rt_rq			*rt_rq;
> > Title claims this change - the rest of the changes should be in a separate
> > patch:
> 
> 
> Okay. I will send v2.

It's ~v7 already by my count, isn't it?

Thanks,

	Ingo

  reply	other threads:[~2023-10-09 11:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-05 16:23 [PATCH 0/2] Move sched_rt_entity::back to RT_GROUP_SCHED Yajun Deng
2023-10-05 16:23 ` [PATCH 1/2] sched/rt: Introduce for_each_sched_rt_entity_back() & use it Yajun Deng
2023-10-05 16:23 ` [PATCH 2/2] sched/rt: Move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block Yajun Deng
2023-10-09 10:16   ` Ingo Molnar
2023-10-09 11:13     ` Yajun Deng
2023-10-09 11:26       ` Ingo Molnar [this message]
2023-10-09 11:31         ` Yajun Deng
2023-10-09 11:54           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZSPjbjPPMeafHbjU@gmail.com \
    --to=mingo@kernel.org \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=yajun.deng@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox