From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58DA0E95A8E for ; Mon, 9 Oct 2023 11:54:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346338AbjJILyX (ORCPT ); Mon, 9 Oct 2023 07:54:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346348AbjJILyU (ORCPT ); Mon, 9 Oct 2023 07:54:20 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D4CAF7 for ; Mon, 9 Oct 2023 04:54:19 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40566f8a093so40953795e9.3 for ; Mon, 09 Oct 2023 04:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696852457; x=1697457257; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=FsXSAz8UwMqpX7LGDxRG7soPkv+HU3a1mUHRtcMadhY=; b=f2p0TT7rNPT7qvSEYuc9EGoA8OkzS6vd3EPvA3qi2TtnWZJFERnJ2RJgPCmlPSuWIW edu+EbLy0/41k1EyMCzldgiHyCBDTOlIUrF+9eL9AX2GsfovadfbtW3h5j+P8jR/5uBr zWj8gNjv+BhwYwIof577MEzDsgqZu85Egfy294GPHCz5owWzQkeK0pAWW6i7tk5tnR2p SzvFvR8HMMeyt6sG1A9TQA3ob1J/25XEuvqSZUzHVg0i6fXb+eyNnHqrVVbK1Lfjn84M aNADdoZ9hbic/Uwsy7UKyKWSOJKfqHpuKTJ/iTYyzRiKCr2y4FFQSSLzTalMYq+z0ICf 6iig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696852457; x=1697457257; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FsXSAz8UwMqpX7LGDxRG7soPkv+HU3a1mUHRtcMadhY=; b=JhTsu7BpLvKjhUs0yxdF+HyAmXl6K9haO1Ce2Cb/d6g3AkFc5CF9l84NrxE+j/dJCb Q3ojT/e0tloOqa9x+Z5sB/cm7WdO+cJsyo/sCOJYHFyqb2gPQCKC5489rjTguKqYI5zP 2ZhgIOdNI/OUzMASd9alRbhYn/sFu01d/tW6qTaieJq7q9PbZONiCIiOlBy9jav7Vsg1 UaJ2j2W6XgVuWy5besKDHK/Ro+/bTK5w6RQ6dc84Cue27jKDiF4s5SLMyQipPT+nVR1B 5OQTD1oxeZuzqm+az41kfznGYx2pp28T7bC5mFpmSMlb9qR6pt4IYbwA3Yf+Ei7Eaxgb TmsQ== X-Gm-Message-State: AOJu0YzuuWNE38xNCM7Le5UcQfkcXGJoHF+DX/DzKy2qILwYyjmmr3jI dq8ax0gpIbmSBoyCzpCgn68= X-Google-Smtp-Source: AGHT+IGwNeouZtTRFX+s4/VTxNEFugSAg+20IibBDZLJhiavF1HcCoPx9hhe3bobqkD/IdOnM43JGg== X-Received: by 2002:a1c:740d:0:b0:405:1ba2:4fd1 with SMTP id p13-20020a1c740d000000b004051ba24fd1mr14127970wmc.24.1696852457355; Mon, 09 Oct 2023 04:54:17 -0700 (PDT) Received: from gmail.com (1F2EF237.nat.pool.telekom.hu. [31.46.242.55]) by smtp.gmail.com with ESMTPSA id 12-20020a05600c024c00b0040531f5c51asm11112782wmj.5.2023.10.09.04.54.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 04:54:16 -0700 (PDT) Sender: Ingo Molnar Date: Mon, 9 Oct 2023 13:54:14 +0200 From: Ingo Molnar To: Yajun Deng Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] sched/rt: Move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block Message-ID: References: <20231005162317.3343678-1-yajun.deng@linux.dev> <20231005162317.3343678-3-yajun.deng@linux.dev> <5a3342ef-f14f-173c-630f-6b474bded257@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Yajun Deng wrote: > > On 2023/10/9 19:26, Ingo Molnar wrote: > > * Yajun Deng wrote: > > > > > On 2023/10/9 18:16, Ingo Molnar wrote: > > > > * Yajun Deng wrote: > > > > > > > > > The member back in struct sched_rt_entity only related to RT_GROUP_SCHED, > > > > > So move sched_rt_entity::back to under the CONFIG_RT_GROUP_SCHED block. It > > > > > will save a few bytes. > > > > > > > > > > Also, init child when parent isn't NULL in init_tg_rt_entry(). > > > > > > > > > > Signed-off-by: Yajun Deng > > > > > --- > > > > > include/linux/sched.h | 2 +- > > > > > kernel/sched/rt.c | 18 +++++++++--------- > > > > > 2 files changed, 10 insertions(+), 10 deletions(-) > > > > > > > > > > diff --git a/include/linux/sched.h b/include/linux/sched.h > > > > > index 292c31697248..d0fe56603e60 100644 > > > > > --- a/include/linux/sched.h > > > > > +++ b/include/linux/sched.h > > > > > @@ -597,8 +597,8 @@ struct sched_rt_entity { > > > > > unsigned short on_rq; > > > > > unsigned short on_list; > > > > > - struct sched_rt_entity *back; > > > > > #ifdef CONFIG_RT_GROUP_SCHED > > > > > + struct sched_rt_entity *back; > > > > > struct sched_rt_entity *parent; > > > > > /* rq on which this entity is (to be) queued: */ > > > > > struct rt_rq *rt_rq; > > > > Title claims this change - the rest of the changes should be in a separate > > > > patch: > > > > > > Okay. I will send v2. > > It's ~v7 already by my count, isn't it? > > > May be. If we count from the earliest. Yes, of course we count from the earliest this series was sent, why wouldn't we? Having new patches or removing patches doesn't really reset the counter. Thanks, Ingo