From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16D07CD80CD for ; Tue, 10 Oct 2023 13:18:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232073AbjJJNSo (ORCPT ); Tue, 10 Oct 2023 09:18:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231681AbjJJNSm (ORCPT ); Tue, 10 Oct 2023 09:18:42 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B546A9; Tue, 10 Oct 2023 06:18:40 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10859"; a="387226907" X-IronPort-AV: E=Sophos;i="6.03,212,1694761200"; d="scan'208";a="387226907" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2023 06:18:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10859"; a="877221493" X-IronPort-AV: E=Sophos;i="6.03,212,1694761200"; d="scan'208";a="877221493" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2023 06:18:38 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC1) (envelope-from ) id 1qqCd9-00000004LgP-33AG; Tue, 10 Oct 2023 16:18:35 +0300 Date: Tue, 10 Oct 2023 16:18:35 +0300 From: Andy Shevchenko To: Mika Westerberg Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/20] pinctrl: intel: cherryview: Convert to platform remove callback returning void Message-ID: References: <20231009083856.222030-1-u.kleine-koenig@pengutronix.de> <20231009083856.222030-6-u.kleine-koenig@pengutronix.de> <20231009111012.GE3208943@black.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231009111012.GE3208943@black.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 09, 2023 at 02:10:12PM +0300, Mika Westerberg wrote: > On Mon, Oct 09, 2023 at 10:38:41AM +0200, Uwe Kleine-König wrote: > > The .remove() callback for a platform driver returns an int which makes > > many driver authors wrongly assume it's possible to do error handling by > > returning an error code. However the value returned is ignored (apart > > from emitting a warning) and this typically results in resource leaks. > > > > To improve here there is a quest to make the remove callback return > > void. In the first step of this quest all drivers are converted to > > .remove_new(), which already returns void. Eventually after all drivers > > are converted, .remove_new() will be renamed to .remove(). > > > > Trivially convert this driver from always returning zero in the remove > > callback to the void returning variant. > > > > Signed-off-by: Uwe Kleine-König > > Acked-by: Mika Westerberg Pushed to my review and testing queue, thanks! -- With Best Regards, Andy Shevchenko