From: Andy Shevchenko <andy@kernel.org>
To: Dipen Patel <dipenp@nvidia.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl,
thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] gpio: tegra186: Set fwnode of the GPIO chip
Date: Tue, 10 Oct 2023 17:13:42 +0300 [thread overview]
Message-ID: <ZSVcFo2sDVbMCW3Z@smile.fi.intel.com> (raw)
In-Reply-To: <ZSVWKSVNsBqDcOFS@smile.fi.intel.com>
On Tue, Oct 10, 2023 at 04:48:25PM +0300, Andy Shevchenko wrote:
> On Tue, Oct 10, 2023 at 04:13:19PM +0300, Andy Shevchenko wrote:
> > On Mon, Oct 09, 2023 at 10:38:58AM -0700, Dipen Patel wrote:
...
> > > + /*
> > > + * This is needed for driver using gpio device matching where it
> > > + * has to use gpio_chip fwnode to match the gpio controller.
> > > + */
> > > + gpio->gpio.fwnode = of_node_to_fwnode(pdev->dev.of_node);
> >
> > of_node_to_fwnode() is specific to IRQ, in other places we use generic
> > of_fwnode_handle(). That's why better just to use dev_fwnode().
>
> On the second thought is there any parent assigned?
> At least I see that in tegra186_gpio_probe(). Are you saying
> it is not working? Or is it (matching) called _before_ we
> add a GPIO device?
Okay, I think I got it. There is a function called tegra_gpiochip_match()
in drivers/hte/hte-tegra194.c which fails after my patch. Yeah, if provider
doesn't set fwnode, it can't match. But, since the driver sets the parent
properly it means that the matching function should be done against the
device.
Seems to me that in HTE code the matching function is broken.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-10-10 14:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 17:38 [PATCH 1/1] gpio: tegra186: Set fwnode of the GPIO chip Dipen Patel
2023-10-10 13:13 ` Andy Shevchenko
2023-10-10 13:48 ` Andy Shevchenko
2023-10-10 14:13 ` Andy Shevchenko [this message]
2023-10-10 14:25 ` Andy Shevchenko
2023-10-10 15:10 ` Bartosz Golaszewski
2023-10-10 15:18 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSVcFo2sDVbMCW3Z@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=dipenp@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox