From: Jon Mason <jdmason@kudzu.us>
To: Max Hawking <maxahawking@sonnenkinder.org>
Cc: Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <allenbh@gmail.com>,
Serge Semin <fancer.lancer@gmail.com>,
Minjie Du <duminjie@vivo.com>,
ntb@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] ntb_perf: Fix printk format
Date: Tue, 10 Oct 2023 11:33:17 -0400 [thread overview]
Message-ID: <ZSVuvSh0B4usJkMX@kudzu.us> (raw)
In-Reply-To: <2ad3273e-1212-428d-b598-e6a82c2bc570@sonnenkinder.org>
On Sun, Oct 08, 2023 at 08:45:16PM -0700, Max Hawking wrote:
> The correct printk format is %pa or %pap, but not %pa[p].
>
> Fixes: 99a06056124d ("NTB: ntb_perf: Fix address err in perf_copy_chunk")
> Signed-off-by: Max Hawking <maxahawking@sonnenkinder.org>
Applied to my ntb branch
Thanks,
Jon
> ---
> drivers/ntb/test/ntb_perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> index 553f1f46bc66..72bc1d017a46 100644
> --- a/drivers/ntb/test/ntb_perf.c
> +++ b/drivers/ntb/test/ntb_perf.c
> @@ -1227,7 +1227,7 @@ static ssize_t perf_dbgfs_read_info(struct file *filep, char __user *ubuf,
> "\tOut buffer addr 0x%pK\n", peer->outbuf);
>
> pos += scnprintf(buf + pos, buf_size - pos,
> - "\tOut buff phys addr %pa[p]\n", &peer->out_phys_addr);
> + "\tOut buff phys addr %pap\n", &peer->out_phys_addr);
>
> pos += scnprintf(buf + pos, buf_size - pos,
> "\tOut buffer size %pa\n", &peer->outbuf_size);
> --
> 2.41.0
>
next prev parent reply other threads:[~2023-10-10 15:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 3:45 [PATCH RESEND] ntb_perf: Fix printk format Max Hawking
2023-10-10 15:33 ` Jon Mason [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-09-10 16:39 Max Hawking
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSVuvSh0B4usJkMX@kudzu.us \
--to=jdmason@kudzu.us \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=duminjie@vivo.com \
--cc=fancer.lancer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxahawking@sonnenkinder.org \
--cc=ntb@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox