* [PATCH RESEND] ntb_perf: Fix printk format
@ 2023-10-09 3:45 Max Hawking
2023-10-10 15:33 ` Jon Mason
0 siblings, 1 reply; 3+ messages in thread
From: Max Hawking @ 2023-10-09 3:45 UTC (permalink / raw)
To: Jon Mason, Dave Jiang, Allen Hubbe, Serge Semin, Minjie Du, ntb,
linux-kernel
The correct printk format is %pa or %pap, but not %pa[p].
Fixes: 99a06056124d ("NTB: ntb_perf: Fix address err in perf_copy_chunk")
Signed-off-by: Max Hawking <maxahawking@sonnenkinder.org>
---
drivers/ntb/test/ntb_perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
index 553f1f46bc66..72bc1d017a46 100644
--- a/drivers/ntb/test/ntb_perf.c
+++ b/drivers/ntb/test/ntb_perf.c
@@ -1227,7 +1227,7 @@ static ssize_t perf_dbgfs_read_info(struct file *filep, char __user *ubuf,
"\tOut buffer addr 0x%pK\n", peer->outbuf);
pos += scnprintf(buf + pos, buf_size - pos,
- "\tOut buff phys addr %pa[p]\n", &peer->out_phys_addr);
+ "\tOut buff phys addr %pap\n", &peer->out_phys_addr);
pos += scnprintf(buf + pos, buf_size - pos,
"\tOut buffer size %pa\n", &peer->outbuf_size);
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH RESEND] ntb_perf: Fix printk format
2023-10-09 3:45 [PATCH RESEND] ntb_perf: Fix printk format Max Hawking
@ 2023-10-10 15:33 ` Jon Mason
0 siblings, 0 replies; 3+ messages in thread
From: Jon Mason @ 2023-10-10 15:33 UTC (permalink / raw)
To: Max Hawking
Cc: Dave Jiang, Allen Hubbe, Serge Semin, Minjie Du, ntb,
linux-kernel
On Sun, Oct 08, 2023 at 08:45:16PM -0700, Max Hawking wrote:
> The correct printk format is %pa or %pap, but not %pa[p].
>
> Fixes: 99a06056124d ("NTB: ntb_perf: Fix address err in perf_copy_chunk")
> Signed-off-by: Max Hawking <maxahawking@sonnenkinder.org>
Applied to my ntb branch
Thanks,
Jon
> ---
> drivers/ntb/test/ntb_perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> index 553f1f46bc66..72bc1d017a46 100644
> --- a/drivers/ntb/test/ntb_perf.c
> +++ b/drivers/ntb/test/ntb_perf.c
> @@ -1227,7 +1227,7 @@ static ssize_t perf_dbgfs_read_info(struct file *filep, char __user *ubuf,
> "\tOut buffer addr 0x%pK\n", peer->outbuf);
>
> pos += scnprintf(buf + pos, buf_size - pos,
> - "\tOut buff phys addr %pa[p]\n", &peer->out_phys_addr);
> + "\tOut buff phys addr %pap\n", &peer->out_phys_addr);
>
> pos += scnprintf(buf + pos, buf_size - pos,
> "\tOut buffer size %pa\n", &peer->outbuf_size);
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH RESEND] ntb_perf: Fix printk format
@ 2023-09-10 16:39 Max Hawking
0 siblings, 0 replies; 3+ messages in thread
From: Max Hawking @ 2023-09-10 16:39 UTC (permalink / raw)
To: Jon Mason, Dave Jiang, Allen Hubbe, Serge Semin, Minjie Du, ntb,
linux-kernel
The correct printk format is %pa or %pap, but not %pa[p].
Fixes: 99a06056124d ("NTB: ntb_perf: Fix address err in perf_copy_chunk")
Signed-off-by: Max Hawking <maxahawking@sonnenkinder.org>
---
drivers/ntb/test/ntb_perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
index 553f1f46bc66..72bc1d017a46 100644
--- a/drivers/ntb/test/ntb_perf.c
+++ b/drivers/ntb/test/ntb_perf.c
@@ -1227,7 +1227,7 @@ static ssize_t perf_dbgfs_read_info(struct file *filep, char __user *ubuf,
"\tOut buffer addr 0x%pK\n", peer->outbuf);
pos += scnprintf(buf + pos, buf_size - pos,
- "\tOut buff phys addr %pa[p]\n", &peer->out_phys_addr);
+ "\tOut buff phys addr %pap\n", &peer->out_phys_addr);
pos += scnprintf(buf + pos, buf_size - pos,
"\tOut buffer size %pa\n", &peer->outbuf_size);
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-10 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-09 3:45 [PATCH RESEND] ntb_perf: Fix printk format Max Hawking
2023-10-10 15:33 ` Jon Mason
-- strict thread matches above, loose matches on Subject: below --
2023-09-10 16:39 Max Hawking
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox