From: Thierry Reding <thierry.reding@gmail.com>
To: Sumit Gupta <sumitg@nvidia.com>
Cc: treding@nvidia.com, jonathanh@nvidia.com,
krzysztof.kozlowski@linaro.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, bbasu@nvidia.com
Subject: Re: [Patch v2 1/2] firmware: tegra: add suspend hook and reset BPMP IPC early on resume
Date: Thu, 12 Oct 2023 13:01:20 +0200 [thread overview]
Message-ID: <ZSfSACoBr1rDF4Gk@orome.fritz.box> (raw)
In-Reply-To: <20231009100557.18224-2-sumitg@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]
On Mon, Oct 09, 2023 at 03:35:56PM +0530, Sumit Gupta wrote:
> Add suspend hook and a 'suspended' field in the 'struct tegra_bpmp'
> to mark if BPMP is suspended. Also, add a 'flags' field in the
> 'struct tegra_bpmp_message' whose 'TEGRA_BPMP_MESSAGE_RESET' bit
> can be set from the Tegra MC driver to signal that the reset of BPMP
> IPC channels is required before sending MRQ to the BPMP FW.
> Together both the fields allow us to handle any requests that might
> be sent too soon as they can cause hang during system resume.
> One case where we see BPMP requests being sent before the BPMP driver
> has resumed is the memory bandwidth requests which are triggered by
> onlining the CPUs during system resume. The CPUs are onlined before
> the BPMP has resumed and we need to reset the BPMP IPC channels to
> handle these requests.
> The additional check for 'flags' is done to avoid any un-intended BPMP
> IPC reset if the tegra_bpmp_transfer*() API gets called during suspend
> sequence after the BPMP driver is suspended.
>
> Fixes: f41e1442ac5b ("cpufreq: tegra194: add OPP support and set bandwidth")
> Co-developed-by: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> ---
> drivers/firmware/tegra/bpmp.c | 30 ++++++++++++++++++++++++++++++
> include/soc/tegra/bpmp.h | 6 ++++++
> 2 files changed, 36 insertions(+)
Krzysztof,
if you want to pick these up instead of me taking them through the Tegra
tree:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-10-12 11:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 10:05 [Patch v2 0/2] Fix hang due to CPU BW request as BPMP suspended Sumit Gupta
2023-10-09 10:05 ` [Patch v2 1/2] firmware: tegra: add suspend hook and reset BPMP IPC early on resume Sumit Gupta
2023-10-12 11:01 ` Thierry Reding [this message]
2023-10-09 10:05 ` [Patch v2 2/2] memory: tegra: set BPMP msg flags to reset IPC channels Sumit Gupta
2023-10-12 11:00 ` Thierry Reding
2023-10-12 13:32 ` Krzysztof Kozlowski
2023-10-12 13:28 ` Krzysztof Kozlowski
2023-10-13 12:25 ` (subset) [Patch v2 0/2] Fix hang due to CPU BW request as BPMP suspended Thierry Reding
2023-10-13 12:36 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSfSACoBr1rDF4Gk@orome.fritz.box \
--to=thierry.reding@gmail.com \
--cc=bbasu@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sumitg@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox