From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98019CDB47E for ; Fri, 13 Oct 2023 11:21:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230463AbjJMLVk (ORCPT ); Fri, 13 Oct 2023 07:21:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230118AbjJMLVi (ORCPT ); Fri, 13 Oct 2023 07:21:38 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C9ECB7 for ; Fri, 13 Oct 2023 04:21:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697196096; x=1728732096; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4qcZWCWIBIltuQKs7SwdL1M/OoXqzM5+6D1gYOXf61Q=; b=Gye196l+sHNeBGmmNgyIVc/hVEdqv62VhMywB0+OUBZupTIbDQNVeK43 KpEGtf5coJYdT7YT34vG06oNeZXv1PYWJYXCBzC73s6WxQeo7qY7578Qa EmXXOZCHPqy83O4aLWvH2gbcx7hYa6gCpmKJx0gqBA5uPE8zguhHdpvvr qQZFrQfWXvIfa+u8FuEGfF7bsRDMF/QnMW80NCjw/3Yz2ukj/kRSeL/iK L5lw+g1H0YF6VgkE0ehpe/BAfPr/4CLjR7Q+RFUPFI1z4kOP12AD0xc8E dS/6bNagvNBjLDxp4YtfYoMsjER9vxZ2bpz06i747JH7LRtmRF/isLuyt A==; X-IronPort-AV: E=McAfee;i="6600,9927,10861"; a="388010205" X-IronPort-AV: E=Sophos;i="6.03,222,1694761200"; d="scan'208";a="388010205" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2023 04:21:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10861"; a="825024794" X-IronPort-AV: E=Sophos;i="6.03,222,1694761200"; d="scan'208";a="825024794" Received: from kesooi-mobl1.gar.corp.intel.com (HELO intel.com) ([10.215.155.173]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2023 04:21:30 -0700 Date: Fri, 13 Oct 2023 13:21:26 +0200 From: Andi Shyti To: Calvince Otieno Cc: outreachy@lists.linux.dev, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Luke Koch , Bagas Sanjaya , Simon Horman , linux-staging@lists.linux.dev Subject: Re: [PATCH v2] staging: wlan-ng: remove helper function prism2sta_inf_handover() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Calvince, ... > @@ -1697,7 +1697,8 @@ void prism2sta_ev_info(struct wlandevice *wlandev, > /* Dispatch */ > switch (inf->infotype) { > case HFA384x_IT_HANDOVERADDR: > - pr_debug("received infoframe:HANDOVER (unhandled)\n"); > + netdev_dbg(wlandev->netdev, > + "received infoframe:HANDOVER (unhandled)\n"); but then you generate this: CHECK: Alignment should match open parenthesis #240: FILE: drivers/staging/wlan-ng/prism2sta.c:1701: + netdev_dbg(wlandev->netdev, + "received infoframe:HANDOVER (unhandled)\n"); total: 0 errors, 0 warnings, 1 checks, 9 lines checked :-) Make it a habit... before sending a patch check it with checkpatch, in order to be sure you are not introducing other checkpatch errors. Don't rush... take your time, check your changes carefully; use checkpatch, compile test, run sparse, etc. Give others time to see your patch and comment. Andi