From: William Breathitt Gray <william.gray@linaro.org>
To: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Cc: lee@kernel.org, alexandre.torgue@foss.st.com,
linux-iio@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/6] counter: stm32-timer-cnt: add support for events
Date: Fri, 13 Oct 2023 19:03:06 -0400 [thread overview]
Message-ID: <ZSnMqienA28Phx6b@fedora> (raw)
In-Reply-To: <20230922143920.3144249-7-fabrice.gasnier@foss.st.com>
[-- Attachment #1: Type: text/plain, Size: 660 bytes --]
On Fri, Sep 22, 2023 at 04:39:20PM +0200, Fabrice Gasnier wrote:
> Add support for capture and overflow events. Also add the related
> validation and configuration. Captured counter value can be retrieved
> through CCRx register. Register and enable interrupts to push events.
>
> Acked-by: Lee Jones <lee@kernel.org>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Hi Fabrice,
Please split the capture and overflow events code to their own patches.
I think there will be some changes to this patch anyway due to the
changes you'll make in the precursor patches, so I'll hold off until v3
to review.
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-10-13 23:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 14:39 [PATCH v2 0/6] counter: fix, improvements and stm32 timer events support Fabrice Gasnier
2023-09-22 14:39 ` [PATCH v2 1/6] tools/counter: add a flexible watch events tool Fabrice Gasnier
2023-10-04 1:37 ` William Breathitt Gray
2023-09-22 14:39 ` [PATCH v2 2/6] counter: stm32-timer-cnt: rename quadrature signal Fabrice Gasnier
2023-09-22 14:39 ` [PATCH v2 3/6] counter: stm32-timer-cnt: rename counter Fabrice Gasnier
2023-09-22 14:39 ` [PATCH v2 4/6] counter: stm32-timer-cnt: introduce clock signal Fabrice Gasnier
2023-10-13 21:22 ` William Breathitt Gray
2023-09-22 14:39 ` [PATCH v2 5/6] counter: stm32-timer-cnt: populate capture channels and check encoder Fabrice Gasnier
2023-10-13 22:48 ` William Breathitt Gray
2023-12-15 17:13 ` Fabrice Gasnier
2023-12-18 17:58 ` William Breathitt Gray
2023-09-22 14:39 ` [PATCH v2 6/6] counter: stm32-timer-cnt: add support for events Fabrice Gasnier
2023-10-13 23:03 ` William Breathitt Gray [this message]
2023-10-13 22:57 ` [PATCH v2 0/6] counter: fix, improvements and stm32 timer events support William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSnMqienA28Phx6b@fedora \
--to=william.gray@linaro.org \
--cc=alexandre.torgue@foss.st.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox