From: Wolfram Sang <wsa@kernel.org>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Samuel Holland <samuel.holland@sifive.com>,
Peter Korsgaard <peter@korsgaard.com>,
Andrew Lunn <andrew@lunn.ch>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: ocores: Move system PM hooks to the NOIRQ phase
Date: Sat, 28 Oct 2023 21:36:05 +0200 [thread overview]
Message-ID: <ZT1ipfs3XzrKChmi@shikoro> (raw)
In-Reply-To: <20231024202030.o3pyswa4css5lnwr@zenone.zhora.eu>
[-- Attachment #1: Type: text/plain, Size: 761 bytes --]
> > When an I2C device contains a wake IRQ subordinate to a regmap-irq chip,
> > the regmap-irq code must be able to perform I2C transactions during
> > suspend_device_irqs() and resume_device_irqs(). Therefore, the bus must
> > be suspended/resumed during the NOIRQ phase.
> >
> > Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
>
> I think this patch has failed to receive some comments, I'll go
> ahead and give it my blessing:
>
> Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
It needs to be rebased on top of 0ad93449b043 ("i2c: ocores: Remove
#ifdef guards for PM related functions"), though. This series did clean
this up for the whole subsystem. It also introduced using pm_sleep_ptr
which probably was missing here?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-10-28 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 20:38 [PATCH] i2c: ocores: Move system PM hooks to the NOIRQ phase Samuel Holland
2023-07-27 0:35 ` Andi Shyti
2023-08-05 1:20 ` Andi Shyti
2023-10-24 20:20 ` Andi Shyti
2023-10-28 19:36 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZT1ipfs3XzrKChmi@shikoro \
--to=wsa@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=andrew@lunn.ch \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@korsgaard.com \
--cc=samuel.holland@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox