From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 792C4CDB482 for ; Thu, 19 Oct 2023 07:13:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232835AbjJSHNe (ORCPT ); Thu, 19 Oct 2023 03:13:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344897AbjJSHN3 (ORCPT ); Thu, 19 Oct 2023 03:13:29 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F3DF192 for ; Thu, 19 Oct 2023 00:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/ExAtAUFm918w30hOEMgGU1kfUzyycn7oMYoVsXzuFQ=; b=SHj4LQnzfHMa1yHTUuvP7nMolw VpESHZXD7leV7Tbxyrk8gTDRViNqV7hH7qjyAKEWJSWNKlsUSjEXsDGqfQHkuNBhM10wHuK18kDBv 6sfgJG1uJU0m0OEIDstoqhoxmXcZCshS/z5rpOaHEiPwEGUsanO8VOHiSc/rk4xoKPerI6QP5fo2x Pj6SuGxSsFToLToB+dKON9i1ajaoXSnK+tXiGX4gvE8SxT+c3ey7hGilx/Dhe6FAnpk4sdQg0XG2E 5szP3MrjA/amJ6XvPiyo0+C/gipY7t1QhISPZ3uSOxSbTzc+lfA9jXw5+PPxc4PZ0iRK8GQtocbhf 1cGobnRA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:40768) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qtNDJ-0006Vk-0Q; Thu, 19 Oct 2023 08:13:01 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qtNDC-0000EU-DM; Thu, 19 Oct 2023 08:12:54 +0100 Date: Thu, 19 Oct 2023 08:12:54 +0100 From: "Russell King (Oracle)" To: Mark-PK Tsai =?utf-8?B?KOiUoeaym+WJmyk=?= Cc: "matthias.bgg@gmail.com" , "angelogioacchino.delregno@collabora.com" , "robin.murphy@arm.com" , "linux-arm-kernel@lists.infradead.org" , "xuewen.yan@unisoc.com" , "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , YJ Chiang =?utf-8?B?KOaxn+iLseadsCk=?= Subject: Re: [PATCH v2] ARM: vfp: Add missing VFP instructions to neon_support_hook Message-ID: References: <20230925131720.7672-1-mark-pk.tsai@mediatek.com> <7e68377e780a2f4312a69ce8afda0cda8ad84568.camel@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7e68377e780a2f4312a69ce8afda0cda8ad84568.camel@mediatek.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 11, 2023 at 02:49:44AM +0000, Mark-PK Tsai (蔡沛剛) wrote: > On Mon, 2023-09-25 at 21:17 +0800, Mark-PK Tsai wrote: > > Add the missing "Unconditional Advanced SIMD and floating-point > > instructions" in [1] to the VFP undef hook. > > > > This commit addresses the issue reported in [2], where > > executing the vudot instruction on a platform with FEAT_DotProd > > support resulted in an undefined instruction error. > > > > Link: > > https://developer.arm.com/documentation/ddi0597/2023-06/?lang=en [1] > > Link: > > https://lore.kernel.org/lkml/20230920083907.30479-1-mark-pk.tsai@mediatek.com/ > > [2] > > Signed-off-by: Mark-PK Tsai > > --- > > arch/arm/vfp/vfpmodule.c | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/arch/arm/vfp/vfpmodule.c b/arch/arm/vfp/vfpmodule.c > > index 7e8773a2d99d..b68efe643a12 100644 > > --- a/arch/arm/vfp/vfpmodule.c > > +++ b/arch/arm/vfp/vfpmodule.c > > @@ -800,6 +800,24 @@ static struct undef_hook neon_support_hook[] = > > {{ > > .cpsr_mask = PSR_T_BIT, > > .cpsr_val = PSR_T_BIT, > > .fn = vfp_support_entry, > > +}, { > > + .instr_mask = 0xff000800, > > + .instr_val = 0xfc000800, > > + .cpsr_mask = 0, > > + .cpsr_val = 0, > > + .fn = vfp_support_entry, > > +}, { > > + .instr_mask = 0xff000800, > > + .instr_val = 0xfd000800, > > + .cpsr_mask = 0, > > + .cpsr_val = 0, > > + .fn = vfp_support_entry, > > +}, { > > + .instr_mask = 0xff000800, > > + .instr_val = 0xfe000800, > > + .cpsr_mask = 0, > > + .cpsr_val = 0, > > + .fn = vfp_support_entry, > > }}; > > Could someone please kindly review this patch? > Thanks. And if someone drops it into the patch system then it might get applied before the merge window. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!