From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF002CDB483 for ; Thu, 19 Oct 2023 16:54:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345212AbjJSQyl (ORCPT ); Thu, 19 Oct 2023 12:54:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230262AbjJSQyi (ORCPT ); Thu, 19 Oct 2023 12:54:38 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E492F12F; Thu, 19 Oct 2023 09:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697734476; x=1729270476; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=LeVge4ZyAQ43SwbJRJwC0GXIoRIycv1Ay0F3olMiVIg=; b=ShlOQ1mCcYP7C5WkreY4/GD3Ph9h0K1ffVPKGQwciIYpHOgIJBUjtdlv RZBevccPCfdaVcM9g+YluWz/Q0HR1qZbplJ18xL9kcjrGjSpdhA9q9bYz Wq5qfcsHjAknexm55k6sEvwMXeRW4Ozge+QVZshOUPcv26zgBjUf7jX0D RxjP9hbJvWMpNdBPV51f6/2mVMmmnDAiwXe4jo7eMHJJ5uaQP6GeRs//H wxTgNyPfpzKcNuEwhTBVFEg3P7UUf9AJlR71Ono/SrNLsl5H2k/DWnlJi Fk+M0F5VsoAxyq7MJWv5QoIM5Om1x8hatGNdTeho0E3lgutUWeKLaM827 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="417423593" X-IronPort-AV: E=Sophos;i="6.03,237,1694761200"; d="scan'208";a="417423593" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2023 09:54:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="706903612" X-IronPort-AV: E=Sophos;i="6.03,237,1694761200"; d="scan'208";a="706903612" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2023 09:54:32 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC2) (envelope-from ) id 1qtWI1-00000006vyR-2m5y; Thu, 19 Oct 2023 19:54:29 +0300 Date: Thu, 19 Oct 2023 19:54:29 +0300 From: Andy Shevchenko To: Andreas Klinger Cc: Jonathan Cameron , Lars-Peter Clausen , Angel Iglesias , Linus Walleij , Sergei Korolev , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iio: bmp280: fix eoc interrupt usage Message-ID: References: <20231018152816.56589-1-ak@it-klinger.de> <20231019162209.18872-1-ak@it-klinger.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231019162209.18872-1-ak@it-klinger.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 19, 2023 at 06:22:09PM +0200, Andreas Klinger wrote: > Only the bmp085 can have an End-Of-Conversion (EOC) interrupt. But the > bmp085 and bmp180 share the same chip id. Therefore it's necessary to > distinguish the case in which the interrupt is set. > > Fix the if statement so that only when the interrupt is set and the chip > id is recognized the interrupt is requested. > > This bug exists since the support of EOC interrupt was introduced. > Fixes: aae953949651 ("iio: pressure: bmp280: add support for BMP085 EOC interrupt") As Jonathan already commented, this is part of a tag block below... > Also add a link to bmp085 datasheet for reference. > ...somewhere here. > Suggested-by: Sergei Korolev > Reviewed-by: Linus Walleij > Signed-off-by: Andreas Klinger > --- > v1 -> v2: Remove extra space (seen by Andy) And seems Jonathan mentioned that this is already fixed in his tree. Did I understand that correctly? -- With Best Regards, Andy Shevchenko