From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBBD0C004C0 for ; Thu, 19 Oct 2023 23:39:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346737AbjJSXjJ (ORCPT ); Thu, 19 Oct 2023 19:39:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235567AbjJSXjI (ORCPT ); Thu, 19 Oct 2023 19:39:08 -0400 Received: from mail-pl1-x64a.google.com (mail-pl1-x64a.google.com [IPv6:2607:f8b0:4864:20::64a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CE07119 for ; Thu, 19 Oct 2023 16:39:06 -0700 (PDT) Received: by mail-pl1-x64a.google.com with SMTP id d9443c01a7336-1c9e994fd94so1777325ad.3 for ; Thu, 19 Oct 2023 16:39:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697758746; x=1698363546; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=jKRVpHqiOcFkAlisvSEFvO+NQRHM9Xm9JCpjQkOWXE8=; b=p7EL6xu2pqmLNepsW0mS2MueKiHF0iLlbEe10hhNH/jYRBqyJTSBzQIoF+GWute3AK LMvn8Lg9U1OX3z9amLPbBL7paP0o1wH1rAeunu/27T+9TPK3G9gndB2JSb+Yxhb/3hJe XuWeAdDYhUa1zbdqgin1D6FDQ2KzFAj5UItYZwxrutnLnvuxtYaA72nwrM3w+AzcRkjC 4L/XUunFGk2OwperCGXsD4m/aB9H1XHt+uchmiVjxPMkCc9AJdnL+a5BGDu0ktV0MlkJ A9QPjHW4HFKFjOIYymRUssbJqVSWTbD3kucttBjnVCXeXeO1Ox/eNNaMX57iRDSpMqf4 jCWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697758746; x=1698363546; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jKRVpHqiOcFkAlisvSEFvO+NQRHM9Xm9JCpjQkOWXE8=; b=aDbw7gRpbMzhrGKM3UHn3o13wkctnLGB0o7ex+Z7ODpRu14expgPG7VIpzX4r6L9sJ j8G1VYtDeoV070164yNv20l5e24auPBta6WAnvga2lmvy+eKJsUSe368CGkVRXoih1v1 I5JbQEn7fyr8nARuvPedVL8/BaNC/Lh/W+ssDYwqNmdeKzSYlrRnXnMa2zjOef6+snYl Nn0Rymej6N6qyq8P+C51845RIPdJ/RhFRzfizsIXPtKMgqB2q9edD62ndvKoGOdhJ9yu a4rEv3MOwkGH3BxdtaVpmtitWOFM9Rlef7ldqu4JV1YxK8dvCwoknpKbIDCMc4aF6CYH NXTQ== X-Gm-Message-State: AOJu0YxzqquWTbBCgkGZk/9baZGnybhLZ7GILRlJwixJMksP6B3uamV5 Pf/Kj6Qx/ofH+kHOeAk+6O4QB3YhqLQ= X-Google-Smtp-Source: AGHT+IEaajjcn0glSm/SziFaaXN2Oe2Bj3k8stVpq3YbjBTLHeHITMz6RMP0euJZHLbenG52J/N+01+5oZI= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:ab0e:b0:1c9:bee2:e20b with SMTP id ik14-20020a170902ab0e00b001c9bee2e20bmr6432plb.11.1697758745829; Thu, 19 Oct 2023 16:39:05 -0700 (PDT) Date: Thu, 19 Oct 2023 16:39:04 -0700 In-Reply-To: <20230911114347.85882-5-cloudliang@tencent.com> Mime-Version: 1.0 References: <20230911114347.85882-1-cloudliang@tencent.com> <20230911114347.85882-5-cloudliang@tencent.com> Message-ID: Subject: Re: [PATCH v4 4/9] KVM: selftests: Test Intel PMU architectural events on gp counters From: Sean Christopherson To: Jinrong Liang Cc: Paolo Bonzini , Like Xu , David Matlack , Aaron Lewis , Vitaly Kuznetsov , Wanpeng Li , Jinrong Liang , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 11, 2023, Jinrong Liang wrote: > +static void test_intel_arch_events(void) > +{ > + uint8_t idx; > + > + for (idx = 0; idx < NR_INTEL_ARCH_EVENTS; idx++) { > + /* > + * Given the stability of performance event recurrence, only > + * these arch events are currently being tested: > + * > + * - Core cycle event (idx = 0) > + * - Instruction retired event (idx = 1) > + * - Reference cycles event (idx = 2) > + * - Branch instruction retired event (idx = 5) > + */ > + if (idx > INTEL_ARCH_INSTRUCTIONS_RETIRED && > + idx != INTEL_ARCH_BRANCHES_RETIRED) > + continue; > + > + check_arch_event_is_unavl(idx); Rather than completely skip the event, just don't check the counter. That way the test still verifies that it can program the event, it's only the result that isn't stable enough to assert on.