From: Phillip Potter <phil@philpotter.co.uk>
To: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cdrom: Missing a blank line after declarations
Date: Fri, 20 Oct 2023 20:01:49 +0100 [thread overview]
Message-ID: <ZTLOnUgfWDHHkHvK@equinox> (raw)
In-Reply-To: <ZS2eKOZF2J7q7zkE@equinox>
On Mon, Oct 16, 2023 at 09:33:44PM +0100, Phillip Potter wrote:
>
> Hi Edson,
>
> Thanks for the patch, looks good to me, will send on for inclusion. That
> said, I will also tweak the title/commit description to a more imperative
> style, given that this description itself currently triggers
> checkpatch.pl due to line length.
>
> Reviewed-by: Phillip Potter <phil@philpotter.co.uk>
>
> Regards,
> Phil
Hi Edson,
After conversing with the Block maintainer (Jens Axboe) it has been
decided that this will not infact be merged, as all it does is introduce
newlines and patches of this type generally just cause problem for
auto-application of patches to stable kernel branches. Thank you anyway
though, and by all means feel free to send other CD-ROM patches my way
in future.
Regards,
Phil
prev parent reply other threads:[~2023-10-20 19:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-15 17:28 [PATCH] cdrom: Missing a blank line after declarations Edson Juliano Drosdeck
2023-10-16 20:33 ` Phillip Potter
2023-10-20 19:01 ` Phillip Potter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTLOnUgfWDHHkHvK@equinox \
--to=phil@philpotter.co.uk \
--cc=edson.drosdeck@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox