From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA862C001DF for ; Fri, 20 Oct 2023 20:34:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230364AbjJTUej (ORCPT ); Fri, 20 Oct 2023 16:34:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230306AbjJTUei (ORCPT ); Fri, 20 Oct 2023 16:34:38 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 192A2C0 for ; Fri, 20 Oct 2023 13:34:37 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C429C433C8; Fri, 20 Oct 2023 20:34:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697834076; bh=LIk4pD6r0C8MAceeSc7n/uK/kd++PAcf0hHLW1YT2YY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pL0hSIJ6yct7jTkjgsaDXZ68Vz8wLV4hTyUfcUpRdHgrVw53VgMjGvnw3ADHn3sot Y0eAdL5wLp2f5w2fxvjIuIorOE9Ey0nBeAc43L14evtQSCqqJ06GeKxq+6gwn74JiR cGpc50EoSIFS0xgQfJmLDVmWXlIXTtKfFv6x/8wzNHWT4c8EMAAwYsqyi+BuUV+III JlBIwXHs36YREKzsBEe7AkQXEZZZwC/+Y33o1ZmbxuWOS7S3NEjKkx0KIi+fYOc/AW 7hL5edQ88wZMcuS6wHDbnmwccKjtj/lWvoNMn8R46l6vzKcNTlxR6TNHdpQYpzIYVD mUMZtNwAG8/XQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id EB5154035D; Fri, 20 Oct 2023 17:34:33 -0300 (-03) Date: Fri, 20 Oct 2023 17:34:33 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Adrian Hunter , Ian Rogers , Jiri Olsa , Linux Kernel Mailing List Subject: Re: [PATCH] perf build: Remove stray '\' before that is warned about since grep 3.8 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Oct 17, 2023 at 12:02:20PM -0700, Namhyung Kim escreveu: > Hi Arnaldo, > > On Tue, Oct 17, 2023 at 11:15 AM Arnaldo Carvalho de Melo > wrote: > > > > To address this grep 3.8 warning: > > > > grep: warning: stray \ before # > > > > Cc: Adrian Hunter > > Cc: Ian Rogers > > Cc: Jiri Olsa > > Cc: Namhyung Kim > > Signed-off-by: Arnaldo Carvalho de Melo > > --- > > tools/perf/Makefile.perf | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > > index 456872ac410df4c0..25d5ccaec22a44fe 100644 > > --- a/tools/perf/Makefile.perf > > +++ b/tools/perf/Makefile.perf > > @@ -361,7 +361,7 @@ python-clean := $(call QUIET_CLEAN, python) $(RM) -r $(PYTHON_EXTBUILD) $(OUTPUT > > ifeq ($(CONFIG_LIBTRACEEVENT),y) > > PYTHON_EXT_SRCS := $(shell grep -v ^\# util/python-ext-sources) > > Do we need to change it here too? Otherwise looks good I think I did tests and simply removing the \ in this case will comment out the rest of the line after the #, IIRC we would have to enclose it in '', like PYTHON_EXT_SRCS := $(shell grep -v '^\#' util/python-ext-sources) But then if it works as-is, why pollute the patch? :-) In general the less lines you touch in a patch, the better, don't fix what isn't broken, helps reviewing, etc. :-) - Arnaldo > Acked-by: Namhyung Kim > > Thanks, > Namhyung > > > > else > > - PYTHON_EXT_SRCS := $(shell grep -v '^\#\|util/trace-event.c' util/python-ext-sources) > > + PYTHON_EXT_SRCS := $(shell grep -v '^#\|util/trace-event.c' util/python-ext-sources) > > endif > > > > PYTHON_EXT_DEPS := util/python-ext-sources util/setup.py $(LIBAPI) > > -- > > 2.41.0 > > -- - Arnaldo