From: Jiri Pirko <jiri@resnulli.us>
To: David Ahern <dsahern@kernel.org>
Cc: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, shuah@kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] selftests:net change ifconfig with ip command
Date: Mon, 23 Oct 2023 09:12:19 +0200 [thread overview]
Message-ID: <ZTYc04N9VK7EarHY@nanopsycho> (raw)
In-Reply-To: <fde654ce-e4b6-449c-94a9-eeaad1eed6b7@kernel.org>
Sun, Oct 22, 2023 at 07:50:52PM CEST, dsahern@kernel.org wrote:
>On 10/22/23 5:31 AM, Swarup Laxman Kotiaklapudi wrote:
>> diff --git a/tools/testing/selftests/net/route_localnet.sh b/tools/testing/selftests/net/route_localnet.sh
>> index 116bfeab72fa..3ab9beb4462c 100755
>> --- a/tools/testing/selftests/net/route_localnet.sh
>> +++ b/tools/testing/selftests/net/route_localnet.sh
>> @@ -18,8 +18,10 @@ setup() {
>> ip route del 127.0.0.0/8 dev lo table local
>> ip netns exec "${PEER_NS}" ip route del 127.0.0.0/8 dev lo table local
>>
>> - ifconfig veth0 127.25.3.4/24 up
>> - ip netns exec "${PEER_NS}" ifconfig veth1 127.25.3.14/24 up
>> + ip a add 127.25.3.4/24 dev veth0
>
>ip addr add ...
Why not "address" then? :)
What's wrong with "a"?
>
>> + ip link set dev veth0 up
>> + ip netns exec "${PEER_NS}" ip a add 127.25.3.14/24 dev veth1
>
>ip addr add ...
>
>> + ip netns exec "${PEER_NS}" ip link set dev veth1 up
>>
>> ip route flush cache
>> ip netns exec "${PEER_NS}" ip route flush cache
>
>
next prev parent reply other threads:[~2023-10-23 7:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-22 11:31 [PATCH] selftests:net change ifconfig with ip command Swarup Laxman Kotiaklapudi
2023-10-22 17:50 ` David Ahern
2023-10-23 7:12 ` Jiri Pirko [this message]
2023-10-23 12:34 ` [PATCH v2] " Swarup Laxman Kotiaklapudi
2023-10-23 14:18 ` David Ahern
2023-10-24 21:00 ` patchwork-bot+netdevbpf
2023-10-23 14:19 ` [PATCH] " David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTYc04N9VK7EarHY@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=swarupkotikalapudi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox