From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB02CC004C0 for ; Mon, 23 Oct 2023 10:56:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230425AbjJWK4M (ORCPT ); Mon, 23 Oct 2023 06:56:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229613AbjJWK4J (ORCPT ); Mon, 23 Oct 2023 06:56:09 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF17BD7C for ; Mon, 23 Oct 2023 03:56:03 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 143CCC433C8; Mon, 23 Oct 2023 10:56:01 +0000 (UTC) Date: Mon, 23 Oct 2023 11:55:59 +0100 From: Catalin Marinas To: Liu Shixin Cc: Patrick Wang , Andrew Morton , Kefeng Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mm/kmemleak: move the initialisation of object to __link_object Message-ID: References: <20231023025125.90972-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231023025125.90972-1-liushixin2@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 23, 2023 at 10:51:25AM +0800, Liu Shixin wrote: > Leave __alloc_object() just do the actual allocation and __link_object() > do the full initialisation. > > Suggested-by: Catalin Marinas > Signed-off-by: Liu Shixin It looks fine to me. Thanks. Reviewed-by: Catalin Marinas