From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BB31C0032E for ; Thu, 26 Oct 2023 01:10:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230460AbjJZBKS (ORCPT ); Wed, 25 Oct 2023 21:10:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229638AbjJZBKQ (ORCPT ); Wed, 25 Oct 2023 21:10:16 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D544ECC for ; Wed, 25 Oct 2023 18:10:14 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-d9cb79eb417so290327276.2 for ; Wed, 25 Oct 2023 18:10:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698282614; x=1698887414; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=DyTK0dPzGluAcQuuHIU80+KHFmV8NJJH2jk5jCqZTKI=; b=minly+N+qkV7I0IFo1WfqDNN0b12/zoxtsjCi3i6hlmXXkujg4SMjup3ho6bYrIAH6 cSsoKJER8wdF2FjpNJfokvS3eIc130UoyLxd1lUlvChfvU2Hwhn6Y5uauUQXxoDZYfbU 9eXxB38+PtUIjZRnZFehDwv5CCHShAw2VB1SOfr0cdUCxJkE2uYAvl9BBwVErKhvuLET 8cHANFe08OCTpJT0Bw8GsdmG4P9toEFRkEDm6wekUziD4VqadzT5YCT9ILIqU22VJRS0 wGmzJSigCI7nyraH7GRd9GrYdZS+Dwn7qB21zhiVdj7CO5MdVaCZ18L5E319Jm0DbXef TTnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698282614; x=1698887414; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DyTK0dPzGluAcQuuHIU80+KHFmV8NJJH2jk5jCqZTKI=; b=fbLBjv16WMGzfafoE7w3nxG4Rb051+sOullNOq5+hDvdmjytwdmPnndIDBxExjfUd+ tmJVHvkl7n/mvNTM+9Ks4i3TlgYrXhn1etNCQlwUoKkAuk2QYRDNTdgRySrvt2b4Wh6u zqJdkyjJbXYysUeEHYSt580tGE7ASKHHlUtyAtJ/2k2J7U5FgYVFfTYfdbOr4nGymdMl AvvvLBV5IVzvRO5+8tWxk1vlu6AugEuDaCSTjoxf4hp9gjlrkf/AwNP7xBexXvMW6hVp ZdOnTwaCuSrckQBFUK+3V1Y07XjfArkupyUG7AgXUjU4jtu+sYDXGTyr2iyg1741eYwJ 8xuw== X-Gm-Message-State: AOJu0YxrI6eDcnSqoj3qEyAlcN9+UW0Vrhvp+cqUYoNYgXYQQHxAbFN2 RCBsZAxSPku4p755iUhKOpu/cSJKMXw= X-Google-Smtp-Source: AGHT+IG5b53M3tonsPzhhr9QutLMpCc9iv9km4Y7t/iM37E2mRMI/XCdaH6nUGaGZ+FXpuIcoFrorwwmlCI= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:1083:b0:d9a:6007:223a with SMTP id v3-20020a056902108300b00d9a6007223amr473790ybu.8.1698282613921; Wed, 25 Oct 2023 18:10:13 -0700 (PDT) Date: Wed, 25 Oct 2023 18:10:12 -0700 In-Reply-To: Mime-Version: 1.0 References: <20231007064019.17472-1-likexu@tencent.com> <53d7caba-8b00-42ab-849a-d8c8d94aea37@gmail.com> Message-ID: Subject: Re: [PATCH] KVM: x86/xsave: Remove 'return void' expression for 'void function' From: Sean Christopherson To: Like Xu Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Maxim Levitsky Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 25, 2023, Sean Christopherson wrote: > On Wed, Oct 25, 2023, Like Xu wrote: > > Emm, did we miss this little fix ? > > No, I have it earmarked, it's just not a priority because it doesn't truly fix > anything. Though I suppose it probably makes to apply it for 6.8, waiting one > more day to send PULL requests to Paolo isn't a problem. Heh, when I tried to apply this I got reminded of why I held it for later. I want to apply it to kvm-x86/misc, but that's based on ~6.6-rc2 (plus a few KVM patches), i.e. doesn't have the "buggy" commit. I don't want to rebase "misc", nor do I want to create a branch and PULL request for a single trivial commit. So for logistical reasons, I'm not going apply this right away, but I will make sure it gets into v6.7.