From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexander Potapenko <glider@google.com>
Cc: catalin.marinas@arm.com, will@kernel.org, pcc@google.com,
andreyknvl@gmail.com, aleksander.lobakin@intel.com,
linux@rasmusvillemoes.dk, yury.norov@gmail.com,
alexandru.elisei@arm.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, eugenis@google.com,
syednwaris@gmail.com, william.gray@linaro.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v9 1/2] lib/bitmap: add bitmap_{read,write}()
Date: Thu, 26 Oct 2023 16:34:24 +0300 [thread overview]
Message-ID: <ZTpq4OiUr+jzeH1q@smile.fi.intel.com> (raw)
In-Reply-To: <CAG_fn=Uv+ox4a1x=-w8DTU_Pj9VPh9TYhBRcDsPh+=Kc2Jsg5w@mail.gmail.com>
On Thu, Oct 26, 2023 at 03:28:25PM +0200, Alexander Potapenko wrote:
...
> > I still didn't get the grouping you implied with this...
>
> Given your second reply, I can disregard this one, right?
Yes.
...
> > > + if (unlikely(!nbits || nbits > BITS_PER_LONG))
> > > + return 0;
> >
> > ...this return in the Return section.
> >
>
> Parameter description for @nbits actually mentions BITS_PER_LONG
> already, so would it be ok to drop the Note: and extend the Returns:
> section as follows:
>
> + * Returns: value of nbits located at the @start bit offset within the @map
> + * memory region. For @nbits = 0 and @nbits > BITS_PER_LONG the return value
> + * is undefined.
>
> ?
Fine to me.
> (Yury didn't want the zero return value to be part of the contract here).
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-10-26 13:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 8:38 [PATCH v9 1/2] lib/bitmap: add bitmap_{read,write}() Alexander Potapenko
2023-10-25 8:38 ` [PATCH v9 2/2] lib/test_bitmap: add tests for bitmap_{read,write}() Alexander Potapenko
2023-10-26 12:15 ` [PATCH v9 1/2] lib/bitmap: add bitmap_{read,write}() Andy Shevchenko
2023-10-26 12:16 ` Andy Shevchenko
2023-10-26 13:28 ` Alexander Potapenko
2023-10-26 13:34 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTpq4OiUr+jzeH1q@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=alexandru.elisei@arm.com \
--cc=andreyknvl@gmail.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pcc@google.com \
--cc=syednwaris@gmail.com \
--cc=will@kernel.org \
--cc=william.gray@linaro.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox