public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Bergh <bergh.jonathan@gmail.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/7] staging: octeon: Fix warnings due to introduction of new typedefs
Date: Thu, 26 Oct 2023 22:02:35 +0200	[thread overview]
Message-ID: <ZTrF27Wm3v0Nn4IA@HP-ENVY-Notebook> (raw)
In-Reply-To: <7e866f48-840a-4b9e-a28d-2016075abb4b@kadam.mountain>

On Mon, Oct 23, 2023 at 05:41:38PM +0300, Dan Carpenter wrote:
> On Sat, Oct 21, 2023 at 12:12:31PM +0200, Jonathan Bergh wrote:
> > This patch series fixes (removes) the introduction of several new typedefs
> > for enums and structs in the octeon driver. First the declarations are
> > fixed and then implementations are updated to remove references to the 
> > old typedefs.
> > 
> > Changelog:
> >  * v1 -> v2: Fix breaking change spread across multiple patches
> >  * v2 -> v3: Break changes up into individual patches for each removed
> >    typedef
> > 
> > Jonathan Bergh (7):
> >   staging: octeon: Fix introduction of new enum typedef cvmx_spi_mode_t
> >     in octeon
> >   staging: octeon: Fix up introduction of new typedef
> >     cvmx_helper_interface_mode_t  in octeon
> >   staging: octeon: Fix introduction of following new typedef
> >     cvmx_pow_wait_t in octeon
> >   staging: octeon: Fix up introduction of new typedef cvmx_pko_lock_t in
> >     octeon
> >   staging: octeon: Fix introduction of new typedef cvmx_pko_status_t in
> >     octeon
> >   staging: octeon: Fix introduction of new typedef
> >     cvmx_pip_port_status_t in octeon
> >   staging: octeon: Fix introduction of new typedef
> >     cvmx_pko_port_status_t in octeon driver
> > 
> >  drivers/staging/octeon/ethernet.c     |  6 ++--
> >  drivers/staging/octeon/octeon-stubs.h | 48 +++++++++++++--------------

Hi
 
> Please don't change the stubs without change the arch/ code.

My tree was out of date, so these changes had already actually been applied
by basically the same patches (ie removing these typedefs) around 17/09 
(Sep).
 
> regards,
> dan carpenter
> 

      reply	other threads:[~2023-10-26 20:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-21 10:12 [PATCH v3 0/7] staging: octeon: Fix warnings due to introduction of new typedefs Jonathan Bergh
2023-10-21 10:12 ` [PATCH v3 1/7] staging: octeon: Fix introduction of new enum typedef cvmx_spi_mode_t in octeon Jonathan Bergh
2023-10-21 10:12 ` [PATCH v3 2/7] staging: octeon: Fix up introduction of new typedef cvmx_helper_interface_mode_t " Jonathan Bergh
2023-10-21 10:12 ` [PATCH v3 3/7] staging: octeon: Fix introduction of following new typedef cvmx_pow_wait_t " Jonathan Bergh
2023-10-21 10:12 ` [PATCH v3 4/7] staging: octeon: Fix up introduction of new typedef cvmx_pko_lock_t " Jonathan Bergh
2023-10-21 10:12 ` [PATCH v3 5/7] staging: octeon: Fix introduction of new typedef cvmx_pko_status_t " Jonathan Bergh
2023-10-21 10:12 ` [PATCH v3 6/7] staging: octeon: Fix introduction of new typedef cvmx_pip_port_status_t " Jonathan Bergh
2023-10-21 10:12 ` [PATCH v3 7/7] staging: octeon: Fix introduction of new typedef cvmx_pko_port_status_t in octeon driver Jonathan Bergh
2023-10-21 20:54 ` [PATCH v3 0/7] staging: octeon: Fix warnings due to introduction of new typedefs Greg KH
2023-10-23 14:41 ` Dan Carpenter
2023-10-26 20:02   ` Jonathan Bergh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZTrF27Wm3v0Nn4IA@HP-ENVY-Notebook \
    --to=bergh.jonathan@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox