From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAE60C25B47 for ; Fri, 27 Oct 2023 07:12:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345381AbjJ0HMP (ORCPT ); Fri, 27 Oct 2023 03:12:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345356AbjJ0HMJ (ORCPT ); Fri, 27 Oct 2023 03:12:09 -0400 Received: from mail.8bytes.org (mail.8bytes.org [85.214.250.239]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E4E131B4 for ; Fri, 27 Oct 2023 00:12:06 -0700 (PDT) Received: from 8bytes.org (p4ffe149c.dip0.t-ipconnect.de [79.254.20.156]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.8bytes.org (Postfix) with ESMTPSA id AED201A55A7; Fri, 27 Oct 2023 09:12:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=8bytes.org; s=default; t=1698390725; bh=fnEddc84wKlKs4bN2NS+++YG0UQjdLnpekj2LzCOah0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y1KIJPTAM1c60H1OtbNcgkyZJ5Yccbtkfyy/5i9+AXNxTQzSzShENsCCiuWbAtqkj 1Gk8LA3o9+wt3pzqsGZA48EuwdN6BYHOApYfmrFB9t0Jj9QX9o0i2vUjx64Fjh6fuJ W34BXp/JZUURZAeICk22PKjbd+swrakeH6tNdBlGxu48C40BXblqevpvho3O4i6o7P rfx2Bi+OXTJL0pledqlpNdj/X6lV8xkfYQvO/t+VP/XWJK+lOpVHbI95RDFjE8tnPF /zHpHdpaBnnw8s8IZqo8Cv/KD8DIcUgBMjhXq2yO21pGzv8GlNwMTryrmGgvA8vBeR 6WXJnVz+2plww== Date: Fri, 27 Oct 2023 09:12:04 +0200 From: Joerg Roedel To: Tina Zhang Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, David Woodhouse , Lu Baolu , Will Deacon , Robin Murphy , Jason Gunthorpe , Kevin Tian , Nicolin Chen , Michael Shavit , Vasant Hegde , Jason Gunthorpe Subject: Re: [PATCH v10 1/6] iommu: Change kconfig around IOMMU_SVA Message-ID: References: <20231027000525.1278806-1-tina.zhang@intel.com> <20231027000525.1278806-2-tina.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231027000525.1278806-2-tina.zhang@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tina, On Fri, Oct 27, 2023 at 08:05:20AM +0800, Tina Zhang wrote: > From: Jason Gunthorpe > > Linus suggested that the kconfig here is confusing: While this patch looks decent to me, you forgot to Cc Linus on it. In general, given that it touches a couple of core files, I'd like to wait for some more people to have a look at it and not rushing anything in. > > https://lore.kernel.org/all/CAHk-=wgUiAtiszwseM1p2fCJ+sC4XWQ+YN4TanFhUgvUqjr9Xw@mail.gmail.com/ > > Let's break it into three kconfigs controlling distinct things: > > - CONFIG_IOMMU_MM_DATA controls if the mm_struct has the additional > fields for the IOMMU. Currently only PASID, but later patches store > a struct iommu_mm_data * > > - CONFIG_ARCH_HAS_CPU_PASID controls if the arch needs the scheduling bit > for keeping track of the ENQCMD instruction. x86 will select this if > IOMMU_SVA is enabled > > - IOMMU_SVA controls if the IOMMU core compiles in the SVA support code > for iommu driver use and the IOMMU exported API > > This way ARM will not enable CONFIG_ARCH_HAS_CPU_PASID > > Signed-off-by: Jason Gunthorpe If you send it, you also need to add your Signed-off-by. Regards, Joerg