* Re: [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility [not found] ` <ccf7d12a-8362-4916-b3e0-f4150f54affd@gmail.com> @ 2023-10-28 7:02 ` Bagas Sanjaya 2023-10-28 10:23 ` Greg Kroah-Hartman 0 siblings, 1 reply; 3+ messages in thread From: Bagas Sanjaya @ 2023-10-28 7:02 UTC (permalink / raw) To: LihaSika, Linux USB, Linux USB Storage, Linux Kernel Mailing List Cc: Alan Stern, Greg Kroah-Hartman, Milan Svoboda, Matthieu Castet [-- Attachment #1: Type: text/plain, Size: 1642 bytes --] On Fri, Oct 27, 2023 at 08:28:04PM +0300, LihaSika wrote: > Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match > 1.50. I have such an older device with bcdDevice=1.50 and it will not work > otherwise. What about below description? ``` Some old USB hard drives using Super Top USB 2.0 SATA bridge have lower minimum bcdDevice value than currently allowed (1.60). Such devices cannot be used by ums-cypress driver since their bcdDevice is out of range. Lower minimum bcdDevice to fix that. ``` > > Cc: stable@vger.kernel.org > Signed-off-by: Liha Sikanen <lihasika@gmail.com> Is your intended author name in your From: header or Signed-off-by: trailer? Also, don't forget to add Fixes: tag; that is: Fixes: a9c143c82608 ("usb-storage: restrict bcdDevice range for Super Top in Cypress ATACB") When above reviews are addressed, resend as v2. Make sure that the patch subject begins with `[PATCH v2]`. > --- > > diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h > index 0547daf..5df4075 100644 > --- a/drivers/usb/storage/unusual_cypress.h > +++ b/drivers/usb/storage/unusual_cypress.h > @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999, > "Cypress ISD-300LP", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > > -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160, > +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160, > "Super Top", > "USB 2.0 SATA BRIDGE", > USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0), > The diff itself is LGTM. Thanks. -- An old man doll... just what I always wanted! - Clara [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility 2023-10-28 7:02 ` [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility Bagas Sanjaya @ 2023-10-28 10:23 ` Greg Kroah-Hartman 2023-10-28 11:05 ` Bagas Sanjaya 0 siblings, 1 reply; 3+ messages in thread From: Greg Kroah-Hartman @ 2023-10-28 10:23 UTC (permalink / raw) To: Bagas Sanjaya Cc: LihaSika, Linux USB, Linux USB Storage, Linux Kernel Mailing List, Alan Stern, Milan Svoboda, Matthieu Castet On Sat, Oct 28, 2023 at 02:02:37PM +0700, Bagas Sanjaya wrote: > On Fri, Oct 27, 2023 at 08:28:04PM +0300, LihaSika wrote: > > Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match > > 1.50. I have such an older device with bcdDevice=1.50 and it will not work > > otherwise. > > What about below description? > > ``` > Some old USB hard drives using Super Top USB 2.0 SATA bridge have lower > minimum bcdDevice value than currently allowed (1.60). Such devices > cannot be used by ums-cypress driver since their bcdDevice is out of range. > > Lower minimum bcdDevice to fix that. > ``` > > > > > Cc: stable@vger.kernel.org > > Signed-off-by: Liha Sikanen <lihasika@gmail.com> > > Is your intended author name in your From: header or Signed-off-by: trailer? > > Also, don't forget to add Fixes: tag; that is: > > Fixes: a9c143c82608 ("usb-storage: restrict bcdDevice range for Super Top in Cypress ATACB") > > When above reviews are addressed, resend as v2. Make sure that the patch > subject begins with `[PATCH v2]`. There's no need, I can take this as-is, thanks. greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility 2023-10-28 10:23 ` Greg Kroah-Hartman @ 2023-10-28 11:05 ` Bagas Sanjaya 0 siblings, 0 replies; 3+ messages in thread From: Bagas Sanjaya @ 2023-10-28 11:05 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: LihaSika, Linux USB, Linux USB Storage, Linux Kernel Mailing List, Alan Stern, Milan Svoboda, Matthieu Castet On 28/10/2023 17:23, Greg Kroah-Hartman wrote: > On Sat, Oct 28, 2023 at 02:02:37PM +0700, Bagas Sanjaya wrote: >> On Fri, Oct 27, 2023 at 08:28:04PM +0300, LihaSika wrote: >>> Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match >>> 1.50. I have such an older device with bcdDevice=1.50 and it will not work >>> otherwise. >> >> What about below description? >> >> ``` >> Some old USB hard drives using Super Top USB 2.0 SATA bridge have lower >> minimum bcdDevice value than currently allowed (1.60). Such devices >> cannot be used by ums-cypress driver since their bcdDevice is out of range. >> >> Lower minimum bcdDevice to fix that. >> ``` >> >>> >>> Cc: stable@vger.kernel.org >>> Signed-off-by: Liha Sikanen <lihasika@gmail.com> >> >> Is your intended author name in your From: header or Signed-off-by: trailer? >> >> Also, don't forget to add Fixes: tag; that is: >> >> Fixes: a9c143c82608 ("usb-storage: restrict bcdDevice range for Super Top in Cypress ATACB") >> >> When above reviews are addressed, resend as v2. Make sure that the patch >> subject begins with `[PATCH v2]`. > > There's no need, I can take this as-is, thanks. > OK, thanks! -- An old man doll... just what I always wanted! - Clara ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-28 11:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <ZTsR-RhhjxSpqrsz@debian.me>
[not found] ` <055de764-c422-4c22-a79b-dd4db56122ce@gmail.com>
[not found] ` <2023102704-stable-lid-c86a@gregkh>
[not found] ` <7484f7c8-a49c-4111-83f0-bb6db2906fae@gmail.com>
[not found] ` <2023102729-spent-ninja-7e39@gregkh>
[not found] ` <037e5af2-3afd-4a37-a4d7-6dc87af605c7@gmail.com>
[not found] ` <21c2b8ee-7753-413e-98f9-d1401edf5c73@gmail.com>
[not found] ` <2023102720-emotion-overlying-9bb4@gregkh>
[not found] ` <ccf7d12a-8362-4916-b3e0-f4150f54affd@gmail.com>
2023-10-28 7:02 ` [PATCH] usb: storage: set 1.50 as the lower bcdDevice for older "Super Top" compatibility Bagas Sanjaya
2023-10-28 10:23 ` Greg Kroah-Hartman
2023-10-28 11:05 ` Bagas Sanjaya
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox