From: Sean Christopherson <seanjc@google.com>
To: Dapeng Mi <dapeng1.mi@linux.intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Kan Liang <kan.liang@linux.intel.com>,
Jim Mattson <jmattson@google.com>,
Jinrong Liang <cloudliang@tencent.com>,
Aaron Lewis <aaronlewis@google.com>, Like Xu <likexu@tencent.com>
Subject: Re: [PATCH v8 07/26] KVM: x86/pmu: Apply "fast" RDPMC only to Intel PMUs
Date: Fri, 10 Nov 2023 06:51:19 -0800 [thread overview]
Message-ID: <ZU5DZ110JPvcmZp0@google.com> (raw)
In-Reply-To: <5d0c1946-0b22-4983-868b-db7f79fe16bc@linux.intel.com>
On Fri, Nov 10, 2023, Dapeng Mi wrote:
>
> On 11/10/2023 10:12 AM, Sean Christopherson wrote:
> > Move the handling of "fast" RDPMC instructions, which drop bits 63:31 of
>
> 63:32?
Oof, yeah.
> > @@ -55,12 +59,17 @@ static struct kvm_pmc *intel_pmc_idx_to_pmc(struct kvm_pmu *pmu, int pmc_idx)
> > }
> > }
> > +static u32 intel_rdpmc_get_masked_idx(struct kvm_pmu *pmu, u32 idx)
>
> inline?
No, for functions that are visible only to the local compilation unit, there's
no reason to use "inline". "inline" is just a hint, and modern compilers are
smart enough to inline functions when appropriate without a hint, e.g. gcc and
clang inline this on all my configurations. Compilers may also ignore the hint,
e.g. KASAN=y tends to produce some really amusing results.
A longer explanation/rant here: https://lore.kernel.org/all/ZAdfX+S323JVWNZC@google.com
next prev parent reply other threads:[~2023-11-10 17:45 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 2:12 [PATCH v8 00/26] KVM: x86/pmu: selftests: Fixes and new tests Sean Christopherson
2023-11-10 2:12 ` [PATCH v8 01/26] KVM: x86/pmu: Always treat Fixed counters as available when supported Sean Christopherson
2023-11-10 2:12 ` [PATCH v8 02/26] KVM: x86/pmu: Allow programming events that match unsupported arch events Sean Christopherson
2023-11-10 2:12 ` [PATCH v8 03/26] KVM: x86/pmu: Remove KVM's enumeration of Intel's architectural encodings Sean Christopherson
2023-11-10 2:12 ` [PATCH v8 04/26] KVM: x86/pmu: Setup fixed counters' eventsel during PMU initialization Sean Christopherson
2023-11-10 2:12 ` [PATCH v8 05/26] KVM: x86/pmu: Get eventsel for fixed counters from perf Sean Christopherson
2023-11-10 13:48 ` Liang, Kan
2023-11-10 2:12 ` [PATCH v8 06/26] KVM: x86/pmu: Don't ignore bits 31:30 for RDPMC index on AMD Sean Christopherson
2023-11-10 2:12 ` [PATCH v8 07/26] KVM: x86/pmu: Apply "fast" RDPMC only to Intel PMUs Sean Christopherson
2023-11-10 3:22 ` Mi, Dapeng
2023-11-10 14:51 ` Sean Christopherson [this message]
2023-11-13 1:24 ` Mi, Dapeng
2023-11-10 2:12 ` [PATCH v8 08/26] KVM: x86/pmu: Disallow "fast" RDPMC for architectural " Sean Christopherson
2023-11-10 6:07 ` Mi, Dapeng
2023-11-10 23:32 ` Sean Christopherson
2023-11-10 2:12 ` [PATCH v8 09/26] KVM: selftests: Add vcpu_set_cpuid_property() to set properties Sean Christopherson
2023-11-10 2:12 ` [PATCH v8 10/26] KVM: selftests: Drop the "name" param from KVM_X86_PMU_FEATURE() Sean Christopherson
2023-11-10 2:12 ` [PATCH v8 11/26] KVM: selftests: Extend {kvm,this}_pmu_has() to support fixed counters Sean Christopherson
2023-11-10 2:12 ` [PATCH v8 12/26] KVM: selftests: Add pmu.h and lib/pmu.c for common PMU assets Sean Christopherson
2023-11-10 2:12 ` [PATCH v8 13/26] KVM: selftests: Test Intel PMU architectural events on gp counters Sean Christopherson
2023-11-10 2:12 ` [PATCH v8 14/26] KVM: selftests: Test Intel PMU architectural events on fixed counters Sean Christopherson
2023-11-10 2:12 ` [PATCH v8 15/26] KVM: selftests: Test consistency of CPUID with num of gp counters Sean Christopherson
2023-11-10 2:12 ` [PATCH v8 16/26] KVM: selftests: Test consistency of CPUID with num of fixed counters Sean Christopherson
2023-11-10 2:12 ` [PATCH v8 17/26] KVM: selftests: Add functional test for Intel's fixed PMU counters Sean Christopherson
2023-11-10 2:12 ` [PATCH v8 18/26] KVM: selftests: Expand PMU counters test to verify LLC events Sean Christopherson
2023-11-10 2:12 ` [PATCH v8 19/26] KVM: selftests: Add a helper to query if the PMU module param is enabled Sean Christopherson
2023-11-10 2:13 ` [PATCH v8 20/26] KVM: selftests: Add helpers to read integer module params Sean Christopherson
2023-11-10 2:13 ` [PATCH v8 21/26] KVM: selftests: Query module param to detect FEP in MSR filtering test Sean Christopherson
2023-11-10 2:13 ` [PATCH v8 22/26] KVM: selftests: Move KVM_FEP macro into common library header Sean Christopherson
2023-11-10 2:13 ` [PATCH v8 23/26] KVM: selftests: Test PMC virtualization with forced emulation Sean Christopherson
2023-11-10 2:13 ` [PATCH v8 24/26] KVM: selftests: Add a forced emulation variation of KVM_ASM_SAFE() Sean Christopherson
2023-11-10 2:13 ` [PATCH v8 25/26] KVM: selftests: Add helpers for safe and safe+forced RDMSR, RDPMC, and XGETBV Sean Christopherson
2023-11-10 2:13 ` [PATCH v8 26/26] KVM: selftests: Extend PMU counters test to validate RDPMC after WRMSR Sean Christopherson
2023-11-13 11:41 ` Jinrong Liang
2023-11-13 13:40 ` Sean Christopherson
2023-11-14 3:07 ` Jinrong Liang
2023-11-10 2:52 ` [PATCH v8 00/26] KVM: x86/pmu: selftests: Fixes and new tests Jinrong Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZU5DZ110JPvcmZp0@google.com \
--to=seanjc@google.com \
--cc=aaronlewis@google.com \
--cc=cloudliang@tencent.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=jmattson@google.com \
--cc=kan.liang@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=likexu@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox