Re: [PATCH v7 06/13] x86: Add early SHA support for Secure Launch early measurements

Eric Biggers
2023-11-11T17:48:16Z

On Fri, Nov 10, 2023 at 05:27:44PM -0500, Ross Philipson wrote:
> arch/x86/boot/compressed/early_sha1.c | 12 ++++
> lib/crypto/sha1.c | 81 +++++++++++++++++++++++++

It's surprising to still see this new use of SHA-1 after so many people objected
to it in the v6 patchset. It's also frustrating that the SHA-1 support is still
being obfuscated by being combined in one patch with SHA-2 support, perhaps in
an attempt to conflate the two algorithms and avoid having to give a rationale
for the inclusion of SHA-1. Finally, new functions should not be added to
lib/crypto/sha1.c unless those functions have multiple users.

- Eric