Re: [PATCH v1 1/1] pinctrl: tangier: Enable 910 Ohm bias

Raag Jadav
2023-10-31T13:59:34Z

On Mon, Oct 30, 2023 at 11:35:42PM +0200, Raag Jadav wrote:
> On Mon, Oct 30, 2023 at 04:14:04PM +0200, Andy Shevchenko wrote:
> > Family 7 (I2C) supports special bias value, i.e. 910 Ohm.
> >
> > Enable it for configuring pin.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/pinctrl/intel/pinctrl-tangier.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/pinctrl/intel/pinctrl-tangier.c b/drivers/pinctrl/intel/pinctrl-tangier.c
> > index 40dd60c9e526..007bca1cf224 100644
> > --- a/drivers/pinctrl/intel/pinctrl-tangier.c
> > +++ b/drivers/pinctrl/intel/pinctrl-tangier.c
> > @@ -382,6 +382,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,
> > case 2000:
> > term = BUFCFG_PUPD_VAL_2K;
> > break;
> > + case 910:
> > + term = BUFCFG_PUPD_VAL_910;
> > + break;
> > default:
> > return -EINVAL;
> > }
> > @@ -405,6 +408,9 @@ static int tng_config_set_pin(struct tng_pinctrl *tp, unsigned int pin,
> > case 2000:
> > term = BUFCFG_PUPD_VAL_2K;
> > break;
> > + case 910:
> > + term = BUFCFG_PUPD_VAL_910;
> > + break;
> > default:
> > return -EINVAL;
> > }
>
> Ah, I failed to notice this was already present in the getter.
>
> Looks good,

Reviewed-by: Raag Jadav <raag.jadav@intel.com>